Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update some system variable #11375

Merged
merged 4 commits into from
Sep 30, 2022
Merged

update some system variable #11375

merged 4 commits into from
Sep 30, 2022

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Sep 21, 2022 •
edited by TomShawn

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 21, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 21, 2022
@TomShawn TomShawn added add-missing-docs Add missing system variables, configuration items, and experimental features to documentation needs-cherry-pick-release-6.2 and removed missing-translation-status This PR does not have translation status info. labels Sep 21, 2022
@TomShawn TomShawn self-assigned this Sep 21, 2022
@TomShawn TomShawn requested review from TomShawn and removed request for shichun-0415 September 21, 2022 09:45
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 21, 2022
@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Sep 21, 2022
TomShawn
TomShawn reviewed Sep 29, 2022
View reviewed changes
system-variables.md Outdated
@@ -205,6 +230,10 @@ mysql> SELECT * FROM t1;
- 单位：秒
- 该变量表示交互式用户会话的空闲超时。交互式用户会话是指使用 `CLIENT_INTERACTIVE` 选项调用 [`mysql_real_connect()`](https://dev.mysql.com/doc/c-api/5.7/en/mysql-real-connect.html) API 建立的会话（例如：MySQL shell 客户端）。该变量与 MySQL 完全兼容。

### `last_insert_id` <span class="version-mark">从 v5.3.0 版本开始引入</span>

- 返回 `LAST_INSERT_ID()` 的结果。与 MySQL 中的 `last_insert_id` 一致。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否有作用域呢？或者是否为只读变量呢？

TomShawn
TomShawn reviewed Sep 29, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
xiongjiwei and others added 2 commits September 29, 2022 15:25
@xiongjiwei @TomShawn
Update system-variables.md
ad1288a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@xiongjiwei
update doc
3d6ccc8
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2022
TomShawn
TomShawn approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 30, 2022
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3d6ccc8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 30, 2022
@ti-chi-bot ti-chi-bot merged commit 2194d6d into pingcap:master Sep 30, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11474.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11475.

TomShawn added a commit that referenced this pull request Sep 30, 2022
@ti-chi-bot @xiongjiwei @TomShawn
update some system variable (#11375) (#11474)
74bcc2f 
* update doc

* update

* Update system-variables.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

* update doc

Co-authored-by: xiongjiwei <xiongjiwei1996@outlook.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Sep 30, 2022
@ti-chi-bot @xiongjiwei @TomShawn
update some system variable (#11375) (#11475)
89fac71 
* update doc

* update

* Update system-variables.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

* update doc

Co-authored-by: xiongjiwei <xiongjiwei1996@outlook.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn mentioned this pull request Oct 8, 2022
Merged
13 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 8, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 8, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11504.

ti-chi-bot added a commit that referenced this pull request Oct 8, 2022
@ti-chi-bot
update some system variable (#11375) (#11504)
fcdeaab
This was referenced Oct 9, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees

@TomShawn TomShawn

Labels
add-missing-docs Add missing system variables, configuration items, and experimental features to documentation needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xiongjiwei @ti-chi-bot @TomShawn @tangenta