Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: add a notice to tiup dm import #11506

Merged
merged 2 commits into from
Oct 9, 2022
Merged

tiup: add a notice to tiup dm import #11506

merged 2 commits into from
Oct 9, 2022

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

Make clear that this command is only used for upgrading DM v1.0 to later versions.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang ran-huang added type/enhancement This issue/PR improves documentation usability or supplements document content. translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-4.0 area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. area/dm needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Oct 8, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 8, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ran-huang ran-huang self-assigned this Oct 8, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2022
@ran-huang ran-huang marked this pull request as draft October 9, 2022 02:08
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2022
@ran-huang ran-huang marked this pull request as ready for review October 9, 2022 03:16
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2022
shichun-0415
shichun-0415 approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2022
@ran-huang ran-huang added the require-LGT1 Indicates that the PR requires an LGTM. label Oct 9, 2022
@ran-huang
Copy link
Contributor Author

/merge

This was referenced Oct 9, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11530.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 9, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11531.

ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
tiup: add a notice to tiup dm import (#11506) (#11523)
dec040d
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
tiup: add a notice to tiup dm import (#11506) (#11524)
d76907a
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 9, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11532.

ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
tiup: add a notice to tiup dm import (#11506) (#11526)
a40780b
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
tiup: add a notice to tiup dm import (#11506) (#11525)
ea0a016
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
tiup: add a notice to tiup dm import (#11506) (#11528)
7e4bcf9
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
tiup: add a notice to tiup dm import (#11506) (#11529)
831dfd7
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
tiup: add a notice to tiup dm import (#11506) (#11527)
f2d0cc9
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
tiup: add a notice to tiup dm import (#11506) (#11531)
43acde3
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
tiup: add a notice to tiup dm import (#11506) (#11530)
b2dd4d3
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
tiup: add a notice to tiup dm import (#11506) (#11532)
cd5167a
@ran-huang ran-huang mentioned this pull request Oct 9, 2022
Merged
13 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 9, 2022
This was referenced Oct 11, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees

@ran-huang ran-huang

Labels
area/dm area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ran-huang @ti-chi-bot @shichun-0415