Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support reloading TLS certificates for TiFlash #12737

Merged
merged 7 commits into from
Feb 14, 2023
Merged

support reloading TLS certificates for TiFlash #12737

merged 7 commits into from
Feb 14, 2023

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Jan 18, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add TiFlash to the certificate reloading section.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 18, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@qiancai qiancai requested a review from lulukelu January 18, 2023 08:44
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2023
@qiancai qiancai added translation/doing This PR’s assignee is translating this PR. area/security Relates to TiDB security and privilege. v6.6 and removed missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2023
@qiancai qiancai requested review from hfxsd and removed request for TomShawn January 18, 2023 08:45
@qiancai qiancai self-assigned this Jan 18, 2023
@qiancai qiancai added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2023
@qiancai qiancai mentioned this pull request Jan 28, 2023
Merged
15 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 28, 2023
hfxsd
hfxsd reviewed Jan 28, 2023
View reviewed changes
enable-tls-between-components.md Show resolved Hide resolved
enable-tls-between-components.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 2, 2023
@qiancai qiancai removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2023
hfxsd
hfxsd reviewed Feb 13, 2023
View reviewed changes
enable-tls-between-components.md
@@ -5,12 +5,11 @@ aliases: ['/docs-cn/dev/enable-tls-between-components/','/docs-cn/dev/how-to/sec

# 为 TiDB 组件间通信开启加密传输
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档缺少 summary ，可以加上

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in ed9c7d9.

hfxsd
hfxsd approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 13, 2023
qiancai and others added 2 commits February 13, 2023 17:32
@qiancai @hfxsd
Update enable-tls-between-components.md
bd97c17 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@qiancai
add a summary
ed9c7d9
@qiancai
Copy link
Collaborator Author

qiancai commented Feb 14, 2023

/merge

@ti-chi-bot
Copy link
Member

@qiancai: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qiancai
Copy link
Collaborator Author

qiancai commented Feb 14, 2023

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2023
@qiancai
Copy link
Collaborator Author

qiancai commented Feb 14, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ed9c7d9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@ti-chi-bot ti-chi-bot merged commit f88ced5 into pingcap:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lulukelu lulukelu lulukelu approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees

@qiancai qiancai

Labels
area/security Relates to TiDB security and privilege. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@qiancai @ti-chi-bot @lulukelu @ywqzzy @hfxsd