Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: update tidb minimal topology from 3 to 2 #12953

Merged
merged 1 commit into from Feb 23, 2023
Merged

*: update tidb minimal topology from 3 to 2 #12953

merged 1 commit into from Feb 23, 2023

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

update tidb minimal topology from 3 to 2

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ran-huang
update tidb minimal topology
eb38589 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang ran-huang added translation/doing This PR’s assignee is translating this PR. area/deploy-upgrade-maintain Indicates that the Issue or PR belongs to the area of deployment, upgrade, and maintenance. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.4 needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Feb 8, 2023
@ran-huang ran-huang self-assigned this Feb 8, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2023
@ran-huang ran-huang added needs-cherry-pick-release-6.6 ONCALL Relates to documentation oncall. labels Feb 17, 2023
shichun-0415
shichun-0415 approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 23, 2023
@ran-huang ran-huang added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 23, 2023
@ran-huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eb38589

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2023
@ti-chi-bot ti-chi-bot merged commit 864999d into pingcap:master Feb 23, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 23, 2023
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #13141.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 23, 2023
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #13142.

@ran-huang ran-huang deleted the fix/minimal-topology branch February 23, 2023 06:24
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 23, 2023
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #13143.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 23, 2023
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #13144.

ti-chi-bot added a commit that referenced this pull request Feb 23, 2023
@ti-chi-bot
*: update tidb minimal topology from 3 to 2 (#12953) (#13141)
5dc3d20
ti-chi-bot added a commit that referenced this pull request Feb 23, 2023
@ti-chi-bot
*: update tidb minimal topology from 3 to 2 (#12953) (#13144)
05725d2
ti-chi-bot added a commit that referenced this pull request Feb 23, 2023
@ti-chi-bot
*: update tidb minimal topology from 3 to 2 (#12953) (#13143)
1e8687a
ti-chi-bot added a commit that referenced this pull request Feb 23, 2023
@ti-chi-bot
*: update tidb minimal topology from 3 to 2 (#12953) (#13142)
670a7fb
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 23, 2023
@shichun-0415 shichun-0415 mentioned this pull request Feb 23, 2023
Merged
16 tasks
ran-huang added a commit to shichun-0415/docs that referenced this pull request Feb 23, 2023
@ran-huang
align with pingcap/docs-cn#12953
7025f12
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 24, 2023
Merged
16 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Feb 24, 2023
@ran-huang @ti-chi-bot
align with pingcap/docs-cn#12953
b3c0235
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 24, 2023
Merged
16 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Feb 24, 2023
@ran-huang @ti-chi-bot
align with pingcap/docs-cn#12953
df3af28
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 24, 2023
Merged
16 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Feb 24, 2023
@ran-huang @ti-chi-bot
align with pingcap/docs-cn#12953
2e04b5b
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 24, 2023
Merged
16 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Feb 24, 2023
@ran-huang @ti-chi-bot
align with pingcap/docs-cn#12953
e610e55
shichun-0415 added a commit to pingcap/docs that referenced this pull request Feb 24, 2023
@ti-chi-bot @shichun-0415
@ran-huang @dveeden
add minimal storage for pd and tidb (#12643) (#12653)
b957200 
* add minimal storage for pd and tidb

* Update minimal-deployment-topology.md

* align with pingcap/docs-cn#12953

* update

* refine

* Apply suggestions from code review

Co-authored-by: Daniël van Eeden <github@myname.nl>

---------

Co-authored-by: shichun-0415 <lishichun@pingcap.com>
Co-authored-by: Ran <huangran.alex@gmail.com>
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
Co-authored-by: Daniël van Eeden <github@myname.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@qqqdan qqqdan Awaiting requested review from qqqdan

Assignees

@shichun-0415 shichun-0415

Labels
area/deploy-upgrade-maintain Indicates that the Issue or PR belongs to the area of deployment, upgrade, and maintenance. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. ONCALL Relates to documentation oncall. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ran-huang @ti-chi-bot @shichun-0415