Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add configuration performance.lite-init-stats #13719

Merged
merged 10 commits into from
Apr 23, 2023
Merged

*: add configuration performance.lite-init-stats #13719

merged 10 commits into from
Apr 23, 2023

Conversation

xuyifangreeneyes
Copy link
Contributor

What is changed, added or deleted? (Required)

Add configuration performance.lite-init-stats.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2023
@hfxsd hfxsd self-assigned this Apr 18, 2023
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. v7.1 This PR/issue applies to TiDB v7.1. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. labels Apr 18, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2023
@hfxsd hfxsd requested a review from Oreoxmt April 18, 2023 07:39
@hfxsd hfxsd added the area/general Relates to TiDB overview, architecture, and other general descriptions. label Apr 18, 2023
Oreoxmt
Oreoxmt approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tidb-configuration-file.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 18, 2023
@hfxsd @Oreoxmt
Update tidb-configuration-file.md
36cfe8a 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Apr 18, 2023 •
edited
Loading

/cc @chrysan

@ti-chi-bot ti-chi-bot requested a review from chrysan April 18, 2023 08:28
@ti-chi-bot
Copy link
Member

@Oreoxmt: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @chrysan PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd changed the title add configuration performance.lite-init-stats *: add configuration performance.lite-init-stats Apr 18, 2023
@hfxsd hfxsd mentioned this pull request Apr 18, 2023
Merged
15 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 18, 2023
@hfxsd hfxsd requested a review from songrijie April 18, 2023 12:36
songrijie
songrijie approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@songrijie songrijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2023
@xuyifangreeneyes
Copy link
Contributor Author

PTAL @hfxsd @songrijie @Oreoxmt

@xuyifangreeneyes xuyifangreeneyes mentioned this pull request Apr 21, 2023
Merged
15 tasks
hfxsd
hfxsd reviewed Apr 21, 2023
View reviewed changes
statistics.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Apr 21, 2023
View reviewed changes
statistics.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Apr 21, 2023
View reviewed changes
statistics.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Apr 21, 2023
View reviewed changes
statistics.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
@hfxsd @Oreoxmt
Apply suggestions from code review
79811bf 
Co-authored-by: Aolin <aolinz@outlook.com>
@hfxsd
Copy link
Collaborator

hfxsd commented Apr 23, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 79811bf

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 23, 2023
@ti-chi-bot ti-chi-bot bot merged commit 641c7ad into pingcap:master Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@songrijie songrijie songrijie approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@chrysan chrysan Awaiting requested review from chrysan

Assignees

@hfxsd hfxsd

Labels
area/general Relates to TiDB overview, architecture, and other general descriptions. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.1 This PR/issue applies to TiDB v7.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xuyifangreeneyes @ti-chi-bot @Oreoxmt @hfxsd @songrijie