Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add document about some new introduced hints #14664

Merged
merged 7 commits into from
Aug 3, 2023
Merged

planner: add document about some new introduced hints #14664

merged 7 commits into from
Aug 3, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jul 31, 2023 •
edited by ran-huang

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 31, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2023

@chrysan: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ran-huang ran-huang self-requested a review August 1, 2023 02:27
@ran-huang ran-huang self-assigned this Aug 1, 2023
@ran-huang ran-huang added the translation/doing This PR’s assignee is translating this PR. label Aug 1, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Aug 1, 2023
@ran-huang ran-huang added the v7.3 This PR/issue applies to TiDB v7.3. label Aug 1, 2023
ran-huang
ran-huang reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

optimizer-hints.md Outdated Show resolved Hide resolved
@ran-huang ran-huang mentioned this pull request Aug 1, 2023
Merged
17 tasks
ran-huang
ran-huang reviewed Aug 1, 2023
View reviewed changes
optimizer-hints.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 PR 需要完整地 cherrypick 到 7.1 和 6.5 吗？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要的

@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 1, 2023
@ran-huang ran-huang requested a review from qiancai August 2, 2023 02:09
@ran-huang ran-huang added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Aug 3, 2023
qiancai
qiancai approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

optimizer-hints.md Outdated Show resolved Hide resolved
@ran-huang @qiancai
Update optimizer-hints.md
4f8714d 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ran-huang
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-03 07:46:41.575797264 +0000 UTC m=+344285.518145782: ☑️ agreed by qiancai.
  • 2023-08-03 08:35:52.268188243 +0000 UTC m=+347236.210536764: ☑️ agreed by ran-huang.

@ran-huang
Copy link
Contributor

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 3, 2023
@ti-chi-bot ti-chi-bot bot merged commit a2e7f8d into pingcap:master Aug 3, 2023
7 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 3, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #14698.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 3, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14699.

@elsa0520 elsa0520 mentioned this pull request Sep 15, 2023
Merged
12 tasks
This was referenced Sep 18, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Sep 21, 2023
@ti-chi-bot
planner: add document about some new introduced hints (#14664) (#14698)
2322fae
ti-chi-bot bot pushed a commit that referenced this pull request Oct 25, 2023
@ti-chi-bot
planner: add document about some new introduced hints (#14664) (#14699)
91b076f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang left review comments

@chrysan chrysan chrysan approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@ran-huang ran-huang

Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.3 This PR/issue applies to TiDB v7.3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@qw4990 @ran-huang @ti-chi-bot @chrysan @qiancai