Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc for tiflash resource control #15043

Merged
merged 24 commits into from Oct 7, 2023

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Sep 15, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • Remove the system variable tidb_enable_tiflash_pipeline_model
  • Control whether to enable TiFlash resource control and Pipeline Model using the TiFlash configuration item enable_resource_control

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 15, 2023
@Oreoxmt Oreoxmt self-requested a review September 15, 2023 03:43
@Oreoxmt Oreoxmt added the v7.4 This PR/issue applies to TiDB v7.4. label Sep 15, 2023
@Oreoxmt Oreoxmt self-assigned this Sep 15, 2023
@Oreoxmt Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label Sep 15, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 15, 2023
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 20, 2023
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2023
@guo-shaoge
Copy link
Contributor Author

/cc @SeaRise

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

@guo-shaoge: GitHub didn't allow me to request PR reviews from the following users: SeaRise.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @SeaRise

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

releases/release-7.2.0.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
guo-shaoge and others added 3 commits September 21, 2023 13:08
Co-authored-by: Aolin <aolinz@outlook.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
…-cn into tiflash_resource_control

Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
tidb-resource-control.md Outdated Show resolved Hide resolved
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

@SeaRise: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
guo-shaoge and others added 2 commits September 22, 2023 13:15
Co-authored-by: Ran <huangran.alex@gmail.com>
Co-authored-by: Ran <huangran.alex@gmail.com>
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-21 13:58:53.858417732 +0000 UTC m=+785099.826005782: ☑️ agreed by Oreoxmt.
  • 2023-09-25 08:26:35.77033697 +0000 UTC m=+263385.488679187: ☑️ agreed by ran-huang.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Sep 27, 2023

/verify

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 7, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit 7d057ad into pingcap:master Oct 7, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.4 This PR/issue applies to TiDB v7.4.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants