Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysvar: add a note about tidb_service_scope #16397

Merged
merged 8 commits into from
Jan 29, 2024
Merged

sysvar: add a note about tidb_service_scope #16397

merged 8 commits into from
Jan 29, 2024

Conversation

Frank945946
Copy link
Collaborator

First-time contributors' checklist

Update the description of DXF

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the contribution Indicates that the PR was contributed by an external member. label Jan 29, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 29, 2024

Hi @Frank945946. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2024
@hfxsd hfxsd self-assigned this Jan 29, 2024
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.6 Should cherry pick this PR to release-7.6 branch. and removed missing-translation-status This PR does not have translation status info. contribution Indicates that the PR was contributed by an external member. needs-ok-to-test labels Jan 29, 2024
hfxsd
hfxsd reviewed Jan 29, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
Benjamin2037
Benjamin2037 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 29, 2024

@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd changed the title Updata DXF sysvar: add a note about tidb_service_scope Jan 29, 2024
hfxsd
hfxsd reviewed Jan 29, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Jan 29, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@hfxsd hfxsd mentioned this pull request Jan 29, 2024
Merged
18 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 29, 2024
qiancai
qiancai approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

system-variables.md Outdated Show resolved Hide resolved
tidb-distributed-execution-framework.md Outdated Show resolved Hide resolved
@hfxsd @qiancai
Apply suggestions from code review
ae415b9 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-29 08:07:26.93318976 +0000 UTC m=+1380088.497487462: ☑️ agreed by qiancai.
  • 2024-01-29 09:51:44.798149624 +0000 UTC m=+1386346.362447329: ☑️ agreed by hfxsd.

@hfxsd
Copy link
Collaborator

hfxsd commented Jan 29, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit 1455a34 into pingcap:master Jan 29, 2024
6 of 7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16416.

This was referenced Jan 29, 2024
Merged
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16417.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 29, 2024
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jan 29, 2024
@ti-chi-bot
sysvar: add a note about tidb_service_scope (#16397) (#16416)
f8afd9b
ti-chi-bot bot pushed a commit that referenced this pull request Jan 29, 2024
@ti-chi-bot
sysvar: add a note about tidb_service_scope (#16397) (#16417)
d3a7952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter left review comments

@hfxsd hfxsd hfxsd approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.6 Should cherry pick this PR to release-7.6 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Frank945946 @hfxsd @ti-chi-bot @D3Hunter @Benjamin2037 @qiancai