Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana: explained metrics in log backup row #17227

Merged
merged 7 commits into from Apr 30, 2024
Merged

grafana: explained metrics in log backup row #17227

merged 7 commits into from Apr 30, 2024

Conversation

YuJuncen
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

This PR added the explanation about the panels of log backup.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@YuJuncen
explained metrics in log backup row
0cd7d55 
Signed-off-by: Yu Juncen <Yu745514916@live.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2024
@hfxsd hfxsd self-assigned this Apr 26, 2024
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Apr 26, 2024
@hfxsd hfxsd self-requested a review April 26, 2024 07:34
BornChanger
BornChanger reviewed Apr 26, 2024
View reviewed changes
grafana-tikv-dashboard.md Outdated Show resolved Hide resolved
grafana-tikv-dashboard.md Outdated Show resolved Hide resolved
@YuJuncen @BornChanger
Apply suggestions from code review
72dcb2a 
Co-authored-by: BornChanger <97348524+BornChanger@users.noreply.github.com>
hfxsd
hfxsd reviewed Apr 29, 2024
View reviewed changes
grafana-tikv-dashboard.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Apr 29, 2024
View reviewed changes
grafana-tikv-dashboard.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Apr 29, 2024
View reviewed changes
grafana-tikv-dashboard.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 29, 2024

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 29, 2024
@hfxsd hfxsd mentioned this pull request Apr 29, 2024
Merged
17 tasks
hfxsd
hfxsd reviewed Apr 30, 2024
View reviewed changes
grafana-tikv-dashboard.md Outdated Show resolved Hide resolved
@YuJuncen @hfxsd
Update grafana-tikv-dashboard.md
915e2d4 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@hfxsd hfxsd requested a review from qiancai April 30, 2024 03:03
hfxsd
hfxsd reviewed Apr 30, 2024
View reviewed changes
grafana-tikv-dashboard.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Apr 30, 2024
View reviewed changes
grafana-tikv-dashboard.md Outdated Show resolved Hide resolved
qiancai
qiancai approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

grafana-tikv-dashboard.md Outdated Show resolved Hide resolved
grafana-tikv-dashboard.md Outdated Show resolved Hide resolved
grafana-tikv-dashboard.md Outdated Show resolved Hide resolved
grafana-tikv-dashboard.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-29 05:39:35.001594846 +0000 UTC m=+249328.758730437: ☑️ agreed by hfxsd.
  • 2024-04-30 06:31:18.922306001 +0000 UTC m=+338832.679441573: ☑️ agreed by qiancai.

@hfxsd @qiancai
Apply suggestions from code review
746322d 
Co-authored-by: Grace Cai <qqzczy@126.com>
@hfxsd
Copy link
Collaborator

hfxsd commented Apr 30, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit c719636 into pingcap:master Apr 30, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #17260.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 30, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #17261.

This was referenced Apr 30, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17262.

This was referenced Apr 30, 2024
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2024
@ti-chi-bot
grafana: explained metrics in log backup row (#17227) (#17260)
73965bb
ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2024
@ti-chi-bot
grafana: explained metrics in log backup row (#17227) (#17261)
ab93c94
ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2024
@ti-chi-bot
grafana: explained metrics in log backup row (#17227) (#17262)
abeea4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

@BornChanger BornChanger BornChanger approved these changes

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YuJuncen @hfxsd @ti-chi-bot @qiancai @BornChanger