Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions-and-operators: function VAR_SAMP()/STDDEV_SAMP() is supported #4533

Merged
merged 3 commits into from Sep 17, 2020

Conversation

Win-Man
Copy link
Contributor

@Win-Man Win-Man commented Sep 17, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Win-Man
Copy link
Contributor Author

Win-Man commented Sep 17, 2020

/cc @SunRunAway @TomShawn

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@SunRunAway,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

@AndreMouche
Copy link
Contributor

/cc TomShawn

@TomShawn TomShawn added needs-cherry-pick-3.0 size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Sep 17, 2020
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 17, 2020
@TomShawn TomShawn merged commit 777f07b into pingcap:master Sep 17, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Sep 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #4534

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Sep 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4535

TomShawn pushed a commit that referenced this pull request Sep 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Win-Man <825895587@qq.com>
TomShawn added a commit that referenced this pull request Sep 17, 2020
…ed (#4533) (#4534)

* cherry pick #4533 to release-3.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update aggregate-group-by-functions.md

* Update functions-and-operators/aggregate-group-by-functions.md

Co-authored-by: Win-Man <825895587@qq.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. translation/no-need No need to translate this PR. and removed requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Sep 17, 2020
@TomShawn TomShawn removed the translation/doing This PR’s assignee is translating this PR. label Sep 18, 2020
@TomShawn
Copy link
Contributor

@Win-Man The function descriptions are incorrectly copied from https://dev.mysql.com/doc/refman/5.7/en/aggregate-functions.html#function_var-samp.
Fixed in #4539.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants