Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update description for analyze version #8412

Merged
merged 5 commits into from
Mar 3, 2022
Merged

Update description for analyze version #8412

merged 5 commits into from
Mar 3, 2022

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Update description for analyze version

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 17, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Feb 17, 2022
@TomShawn TomShawn self-assigned this Feb 17, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 17, 2022
@TomShawn TomShawn added needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Feb 17, 2022
@yiwen92
Copy link
Contributor

yiwen92 commented Feb 17, 2022

tidb analyze version = 2 在 v5.3 之后应该不算是实验特性了吧。 @winoros

qiancai
qiancai reviewed Feb 18, 2022
View reviewed changes
statistics.md Outdated Show resolved Hide resolved
@TomShawn @qiancai
Update statistics.md
6089601 
Co-authored-by: Grace Cai <qqzczy@126.com>
@winoros
Copy link
Member

winoros commented Mar 2, 2022

@yiwen92 想在集群升级之后也使用 version 2 的时候再去掉实验性功能

TomShawn
TomShawn commented Mar 3, 2022
View reviewed changes
statistics.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Mar 3, 2022
View reviewed changes
statistics.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Mar 3, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
qiancai
qiancai approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 3, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Mar 3, 2022

/verify

@TomShawn
Copy link
Contributor Author

TomShawn commented Mar 3, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 3, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Mar 3, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7a8ea0d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 3, 2022
@ti-chi-bot ti-chi-bot merged commit a175009 into pingcap:master Mar 3, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 3, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8552.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 3, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8553.

ti-chi-bot added a commit that referenced this pull request Mar 4, 2022
@ti-chi-bot
Update description for analyze version (#8412) (#8552)
12a0036
ti-chi-bot added a commit that referenced this pull request Mar 4, 2022
@ti-chi-bot
Update description for analyze version (#8412) (#8553)
9371389
@TomShawn TomShawn deleted the update-description-for-analyze-version branch March 21, 2022 08:10
@TomShawn TomShawn mentioned this pull request Mar 21, 2022
Merged
15 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 21, 2022
This was referenced Apr 13, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@qiancai qiancai qiancai approved these changes

@yiwen92 yiwen92 Awaiting requested review from yiwen92

Assignees

@TomShawn TomShawn

Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TomShawn @ti-chi-bot @yiwen92 @winoros @qiancai