Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd ctl: change the remove to add #880

Merged
merged 1 commit into from
Sep 13, 2018
Merged

pd ctl: change the remove to add #880

merged 1 commit into from
Sep 13, 2018

Conversation

liukun4515
Copy link
Contributor

@liukun4515 liukun4515 commented Sep 12, 2018 •
edited

related pr: #616

@liukun4515
Copy link
Contributor Author

PTAL @nolouch @disksing

@liukun4515
Copy link
Contributor Author

PTAL @lilin90

lilin90
lilin90 reviewed Sep 13, 2018
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liukun4515 liukun4515 mentioned this pull request Sep 13, 2018
Merged
@lilin90 lilin90 merged commit 9ec0faa into pingcap:master Sep 13, 2018
@sre-bot sre-bot added the contribution Indicates that the PR was contributed by an external member. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 left review comments

@disksing disksing disksing approved these changes

Assignees
No one assigned
Labels
contribution Indicates that the PR was contributed by an external member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liukun4515 @disksing @lilin90 @sre-bot