Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add more commands in pd-control #881

Merged
merged 2 commits into from
Sep 17, 2018
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 12, 2018

This PR is related to pingcap/docs#619.

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2018

CLA assistant check
All committers have signed the CLA.

@@ -463,6 +463,76 @@ Protobuf 格式示例:
}
```

### `region store <store_id>`

用于查询某个 store 上面所有的 region。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

region -> Region
Please also update other similar "region"s involved in this PR.

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

>> operator add transfer-peer 1 2 3 // 把 Region 1 在 store 2 上的副本调度到 store 3
>> operator add merge-region 1 2 // 将 Region 1 与 Region 2 合并
>> operator add split-region 1 --policy=approximate // 将 Region 1 对半拆分成两个 region,基于粗略估计值
>> operator add split-region 1 --policy=scan // 将 Region 1 对半拆分成两个 region,基于精确扫描值
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also help update the 2 "region"s in line 383&384 to keep them consistent with others. Thanks!

@rleungx
Copy link
Member Author

rleungx commented Sep 17, 2018

PTAL. @lilin90

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit b3e1216 into pingcap:master Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants