Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release notes: add v5.4.1 release notes #9264

Merged
merged 34 commits into from
May 13, 2022
Merged

release notes: add v5.4.1 release notes #9264

merged 34 commits into from
May 13, 2022

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Apr 29, 2022 •
edited

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 29, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 29, 2022
@qiancai qiancai added translation/from-docs This PR is translated from a PR in pingcap/docs. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 29, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Apr 29, 2022
@qiancai qiancai added area/general Relates to TiDB overview, architecture, and other general descriptions. missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 29, 2022
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 29, 2022
AndreMouche
AndreMouche reviewed May 6, 2022
View reviewed changes
releases/release-5.4.1.md Outdated Show resolved Hide resolved
releases/release-5.4.1.md Outdated Show resolved Hide resolved
3pointer
3pointer reviewed May 7, 2022
View reviewed changes
releases/release-5.4.1.md Outdated Show resolved Hide resolved
cfzjywxk
cfzjywxk reviewed May 7, 2022
View reviewed changes
releases/release-5.4.1.md Outdated Show resolved Hide resolved
releases/release-5.4.1.md Show resolved Hide resolved
releases/release-5.4.1.md Outdated Show resolved Hide resolved
qiancai
qiancai commented May 9, 2022
View reviewed changes
releases/release-5.4.1.md Outdated Show resolved Hide resolved
qiancai and others added 3 commits May 9, 2022 10:55
@qiancai
Update releases/release-5.4.1.md
8fa4145
@qiancai @cfzjywxk
@AndreMouche @guo-shaoge
Apply suggestions from code review
886bd52 
Co-authored-by: cfzjywxk <lsswxrxr@163.com>
Co-authored-by: Shirly <AndreMouche@126.com>
Co-authored-by: guo-shaoge <shaoge1994@163.com>
@qiancai
apply review comments
d0271f6
qiancai and others added 2 commits May 12, 2022 14:24
bb7133
bb7133 reviewed May 12, 2022
View reviewed changes
releases/release-5.4.1.md Outdated

+ TiDB

- (dup: release-6.0.0-dmr.md > Bug 修复> TiDB)- 修复 date_format 对 `'\n'` 的处理与 MySQL 不兼容的问题 [#32232](https://github.com/pingcap/tidb/issues/32232)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bugfix, I think we can remove it.

Copy link
Contributor

@TomShawn TomShawn May 12, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiancai Maybe we can move it to the bug fix part?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AndreMouche
AndreMouche approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tiancaiamao
tiancaiamao approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@tiancaiamao tiancaiamao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TiDB part LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2022
TomShawn
TomShawn approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hfxsd
hfxsd approved these changes May 13, 2022
View reviewed changes
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiancai
Copy link
Collaborator Author

qiancai commented May 13, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9111b91

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022
@ti-chi-bot ti-chi-bot merged commit 860ec65 into pingcap:master May 13, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9467.

@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9468.

ti-chi-bot added a commit that referenced this pull request May 13, 2022
@ti-chi-bot
release notes: add v5.4.1 release notes (#9264) (#9467)
41929b9
ti-chi-bot added a commit that referenced this pull request May 19, 2022
@ti-chi-bot
release notes: add v5.4.1 release notes (#9264) (#9468)
95215e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@JaySon-Huang JaySon-Huang JaySon-Huang left review comments

@3pointer 3pointer 3pointer left review comments

@Reminiscent Reminiscent Reminiscent left review comments

@AndreMouche AndreMouche AndreMouche approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@hfxsd hfxsd hfxsd approved these changes

@TomShawn TomShawn TomShawn approved these changes

@ran-huang ran-huang ran-huang approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees
No one assigned
Labels
area/general Relates to TiDB overview, architecture, and other general descriptions. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet