Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a TiDB FAQ about supported storage engine #9490

Merged
merged 3 commits into from
May 16, 2022

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

Update a TiDB FAQ

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lilin90
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 16, 2022
@TomShawn TomShawn self-assigned this May 16, 2022
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. ONCALL Relates to documentation oncall. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 and removed missing-translation-status This PR does not have translation status info. labels May 16, 2022
@lilin90 lilin90 changed the title Update a TiDB FAQ Update a TiDB FAQ about supported storage engine May 16, 2022
faq/tidb-faq.md Outdated
@@ -49,7 +49,30 @@ TiDB 事务模型灵感源自 Google Percolator 模型,主体是一个两阶

#### 1.1.9 TiDB 是否支持其他存储引擎?

是的,除了 TiKV 之外,TiDB 还支持一些流行的单机存储引擎,比如 GolevelDB、RocksDB、BoltDB 等。如果一个存储引擎是支持事务的 KV 引擎,并且能提供一个满足 TiDB 接口要求的 Client,即可接入 TiDB。
是的,除了 TiKV 之外,TiDB 还支持一些单机存储引擎,比如 MockTiKV 和 UniStore。注意,未来 TiDB 版本可能不再支持 MockTiKV。
Copy link
Member

@lilin90 lilin90 May 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiancaiamao

  1. 这句话要不要保留呢? 如果一个存储引擎是支持事务的 KV 引擎,并且能提供一个满足 TiDB 接口要求的 Client,即可接入 TiDB。
  2. 未来 TiDB 版本可能不再支持 MockTiKV 这里的 未来 能否稍微具体一下?
  3. 除了 TiKV 之外 处是否要提 TiFlash,即改为 除了 TiKV 和 TiFlash 之外

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 如果一个存储引擎是支持事务的 KV 引擎,并且能提供一个满足 TiDB 接口要求的 Client,即可接入 TiDB ... 这个是历史问题,最初的 tidb 代码很简单时,只要随便弄一个 kv 引擎,实现 Client 接口就可以接入 TiDB 了... 等后来 tidb 越来越复杂,需要实现复杂的事务协议,并且实现 coprocessor 的相关接口,这已经不是随便拿一个 kv 引擎很容易能实现的了
  2. 我们做 mocktikv 主要是用来跑测试用。再做后来 unistore 是为了更好的性能以及一些实验性特性的验证... 等 unistore 成熟后就拿它当默认的跑测试用。当前已经没有在 MockTiKV 上面做任何修改了,MockTiKV 已经属于废弃状态... 不过还没有做清理,并且 tidb 的 -store=mocktikv 还在,未来 如果清理掉代码,这个就不支持了
  3. TiFlash 其实不算一个完整的实现,它只实现了读,没有实现写。TiDB 是不能直接写入 TiFlash 的,不过可以读... 也就是 TiFlash 只实现了 Client 接口其中 coprocessor 一部分的 API,但是没实现事务部分的 API

faq/tidb-faq.md Outdated Show resolved Hide resolved
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 16, 2022
@TomShawn TomShawn requested a review from lilin90 May 16, 2022 07:17
faq/tidb-faq.md Outdated Show resolved Hide resolved
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 16, 2022
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 28367cb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 16, 2022
@ti-chi-bot ti-chi-bot merged commit 24741b7 into pingcap:master May 16, 2022
@TomShawn TomShawn deleted the tidb-faq-engine-update branch May 16, 2022 07:28
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9491.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9492.

@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants