zh,en: bring relay log back #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
reviewed
Dec 18, 2020
| Method 1: Use the command-line options. | ||
| ```yaml | ||
| # relay log purge strategy | ||
| purge: |
There was a problem hiding this comment.
for YAML, you can update the following config items, like purge-interval to purge.interval.
|
|
||
| ```yaml | ||
| # relay log purge strategy | ||
| purge: |
7 tasks
CharLotteiu
added
needs-cherry-pick-release-2.0
CharLotteiu
reviewed
Dec 18, 2020
en/source-configuration-file.md
Outdated
|
|
||
| > **Note:** | ||
| > | ||
| > The automatic cleanup policy will only take effect when `interval` is not 0 and at least one of the two configuration items `expires` and `remain-space` is not 0. |
There was a problem hiding this comment.
Suggested change
| > The automatic cleanup policy will only take effect when `interval` is not 0 and at least one of the two configuration items `expires` and `remain-space` is not 0. | |
| > The automatic data purge strategy only takes effect when `interval` is not 0 and at least one of the two configuration items `expires` and `remain-space` is not 0. |
There was a problem hiding this comment.
address in ebb7bb3
|
@csuzhangxc, @CharLotteiu, @yikeke, PTAL. |
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
|
@yikeke, PTAL. |
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
|
LGTM |
ti-srebot
approved these changes
Dec 25, 2020
ti-srebot
pushed a commit
to ti-srebot/docs-dm
that referenced
this pull request
Dec 25, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
7 tasks
|
cherry pick to release-2.0 in PR #528 |
CharLotteiu
pushed a commit
that referenced
this pull request
Dec 25, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: GMHDBJD <35025882+GMHDBJD@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added, or deleted? (Required)
bring relay log back
Which DM version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
pingcap/dm#1291
Do your changes match any of the following descriptions?