Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spaces in options (#2452) #2453

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2452

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Remove some spaces in the option, which cause "error: unknown flag: --from-", when create secrete from command line.

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot ti-chi-bot added contribution Indicates that the PR was contributed by an external member. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-1.4 This PR is cherry-picked to release-1.4 from a source PR. labels Sep 26, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 26, 2023
6 tasks
@ran-huang
Copy link
Contributor

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 26, 2023
@ti-chi-bot ti-chi-bot bot merged commit 48d28ee into pingcap:release-1.4 Sep 26, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution Indicates that the PR was contributed by an external member. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-1.4 This PR is cherry-picked to release-1.4 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants