Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify use of topologySpreadConstraints #2464

Merged

Conversation

ran-huang
Copy link
Contributor

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang added translation/from-en This PR is translated from a PR in docs-tidb-operator/en. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. labels Nov 6, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2023
Copy link

ti-chi-bot bot commented Nov 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-06 07:09:24.798597641 +0000 UTC m=+3455362.385707771: ☑️ agreed by csuzhangxc.
  • 2023-11-06 08:02:15.846024198 +0000 UTC m=+3458533.433134342: ☑️ agreed by Oreoxmt.

@ran-huang
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 6, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4884bb9 into pingcap:master Nov 6, 2023
13 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.5: #2465.

@ran-huang ran-huang deleted the topologySpreadConstraints-2448 branch November 6, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-en This PR is translated from a PR in docs-tidb-operator/en.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants