Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM: Revise wrong syntax for command example on get into the pod in eng doc #2587

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

Jingyuma
Copy link
Contributor

#2586 Example syntax error in eng doc.

What is changed, added, or deleted? (Required)

Add a hyphen on kubectl command: from kubectl exec -it - to kubectl exec -it --
because - is not valid syntax, and will throw an error message. Detail inside the #2586

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

NA

  • This PR is translated from:
  • Other reference link(s):

pingcap#2586
Example syntax error in eng doc.
@ti-chi-bot ti-chi-bot bot added contribution Indicates that the PR was contributed by an external member. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2024
Copy link

ti-chi-bot bot commented Jul 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-01 01:39:56.352818216 +0000 UTC m=+1202122.838307048: ☑️ agreed by csuzhangxc.
  • 2024-07-09 03:21:17.079352568 +0000 UTC m=+327774.314586682: ☑️ agreed by Oreoxmt.
  • 2024-07-09 03:21:23.081274712 +0000 UTC m=+327780.316508824: ☑️ agreed by Oreoxmt.

@Oreoxmt Oreoxmt added translation/no-need The changes in this PR don't need to be translated. type/bug-fix Fixes typos or wrong format. needs-cherry-pick-release-1.2 Should cherry pick this PR to release-1.2 branch. needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. labels Jul 9, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jul 9, 2024
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 9, 2024

/approve

Copy link

ti-chi-bot bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit 09664e6 into pingcap:master Jul 9, 2024
13 of 14 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.3: #2589.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.4: #2590.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.5: #2591.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.6: #2592.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.2: #2593.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution Indicates that the PR was contributed by an external member. lgtm needs-cherry-pick-release-1.2 Should cherry pick this PR to release-1.2 branch. needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need The changes in this PR don't need to be translated. type/bug-fix Fixes typos or wrong format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants