Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

en: fix tidb-operator chart notes #439

Merged
merged 3 commits into from
Jun 19, 2020
Merged

en: fix tidb-operator chart notes #439

merged 3 commits into from
Jun 19, 2020

Conversation

weekface
Copy link
Contributor

What is changed, added or deleted? (Required)

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.1 (TiDB Operator 1.1 versions)
  • v1.0 (TiDB Operator 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ran-huang ran-huang added needs-cherry-pick-release-1.1 Should cherry pick this PR to release-1.1 branch. translation/doing This PR’s assignee is translating this PR. labels Jun 18, 2020
@ran-huang ran-huang self-assigned this Jun 18, 2020
ran-huang
ran-huang reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DanielZhangQD
DanielZhangQD approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 19, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

1 similar comment
@ran-huang
Copy link
Contributor

/run-all-tests

@CLAassistant
Copy link

CLAassistant commented Jun 19, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@ran-huang ran-huang added translation/no-need The changes in this PR don't need to be translated. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 19, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit ede0160 into pingcap:master Jun 19, 2020
ti-srebot pushed a commit to ti-srebot/docs-tidb-operator that referenced this pull request Jun 19, 2020
@weekface @ti-srebot
cherry pick pingcap#439 to release-1.1
4e1ce27 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 19, 2020
Merged
3 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #451

DanielZhangQD pushed a commit that referenced this pull request Jun 19, 2020
@ti-srebot @weekface
cherry pick #439 to release-1.1 (#451)
5c76a8f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: weekface <weekface@gmail.com>
@cofyc cofyc mentioned this pull request Jul 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang left review comments

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

Assignees

@ran-huang ran-huang

Labels
needs-cherry-pick-release-1.1 Should cherry pick this PR to release-1.1 branch. status/can-merge Indicates a PR has been approved by a committer. translation/no-need The changes in this PR don't need to be translated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@weekface @ran-huang @ti-srebot @CLAassistant @DanielZhangQD