Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

en: add helm offline doc #503

Merged
merged 6 commits into from
Jun 30, 2020
Merged

en: add helm offline doc #503

merged 6 commits into from
Jun 30, 2020

Conversation

DanielZhangQD
Copy link
Contributor

@DanielZhangQD DanielZhangQD commented Jun 28, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Add the doc to install and use helm offline

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.1 (TiDB Operator 1.1 versions)
  • v1.0 (TiDB Operator 1.0 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang requested review from ran-huang and removed request for yikeke June 29, 2020 05:02
@ran-huang ran-huang added the needs-cherry-pick-release-1.1 Should cherry pick this PR to release-1.1 branch. label Jun 29, 2020
@ran-huang ran-huang requested review from yikeke and removed request for ran-huang June 29, 2020 05:04
@ran-huang ran-huang added the translation/from-zh This PR is translated from a PR in docs-tidb-operator/zh. label Jun 29, 2020
@yikeke yikeke requested review from ran-huang and removed request for yikeke June 29, 2020 06:53
ran-huang
ran-huang reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great translation😃

en/tidb-toolkit.md Outdated Show resolved Hide resolved
en/tidb-toolkit.md Outdated Show resolved Hide resolved
en/tidb-toolkit.md Outdated Show resolved Hide resolved
en/tidb-toolkit.md Outdated Show resolved Hide resolved
en/tidb-toolkit.md Show resolved Hide resolved
en/tidb-toolkit.md Outdated Show resolved Hide resolved
en/tidb-toolkit.md Show resolved Hide resolved
en/tidb-toolkit.md Outdated Show resolved Hide resolved
en/tidb-toolkit.md Outdated Show resolved Hide resolved
en/tidb-toolkit.md Outdated Show resolved Hide resolved
DanielZhangQD
DanielZhangQD commented Jun 30, 2020
View reviewed changes
en/tidb-toolkit.md Outdated Show resolved Hide resolved
ran-huang
ran-huang approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

en/tidb-toolkit.md Outdated Show resolved Hide resolved
@DanielZhangQD @ran-huang
Apply suggestions from code review
d3b6ace 
Co-authored-by: Ran <huangran@pingcap.com>
@DanielZhangQD DanielZhangQD merged commit 9f5ad01 into pingcap:master Jun 30, 2020
@DanielZhangQD DanielZhangQD deleted the off0 branch June 30, 2020 06:24
ti-srebot pushed a commit to ti-srebot/docs-tidb-operator that referenced this pull request Jun 30, 2020
@DanielZhangQD @ti-srebot
cherry pick pingcap#503 to release-1.1
955d611 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 30, 2020
Merged
3 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #520

DanielZhangQD added a commit that referenced this pull request Jun 30, 2020
@ti-srebot @DanielZhangQD
cherry pick #503 to release-1.1 (#520)
3816a2b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weekface weekface weekface approved these changes

@ran-huang ran-huang ran-huang approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-1.1 Should cherry pick this PR to release-1.1 branch. translation/from-zh This PR is translated from a PR in docs-tidb-operator/zh.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DanielZhangQD @ti-srebot @weekface @ran-huang