Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Aolin <aolinz@outlook.com>
  • Loading branch information
ran-huang and Oreoxmt committed Mar 20, 2023
1 parent abf6128 commit c020151
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion optimizer-hints.md
Expand Up @@ -323,7 +323,7 @@ SELECT /*+ MPP_1PHASE_AGG() */ COUNT(*) FROM t1, t2 WHERE t1.a > 10 GROUP BY t1.

> **Note:**
>
> - Before using this hint, make sure that the current TiDB cluster can support using TiFlash MPP mode in the query. For details, refer to [Use TiFlash MPP Mode](/tiflash/use-tiflash-mpp-mode.md).
> Before using this hint, make sure that the current TiDB cluster can support using TiFlash MPP mode in the query. For details, refer to [Use TiFlash MPP Mode](/tiflash/use-tiflash-mpp-mode.md).
### MPP_2PHASE_AGG()

Expand Down
4 changes: 2 additions & 2 deletions system-variables.md
Expand Up @@ -3016,11 +3016,11 @@ mysql> desc select count(distinct a) from test.t;
- Persists to cluster: Yes
- Type: Boolean
- Default value: `ON`
- This variable is used to control whether the Join Method Hint, such as [`HASH_JOIN()` Hint](/optimizer-hints.md#hash_joint1_name--tl_name-) and [`MERGE_JOIN()` Hint](/optimizer-hints.md#merge_joint1_name--tl_name-), affects the Join Reorder optimization process, including the use of [`LEADING()` Hint](/optimizer-hints.md#leadingt1_name--tl_name-). The default value is `ON`, which means that it does not affect. If it is set to `OFF`, there may be conflicts in some scenarios where both Join Method Hint and `LEADING()` Hint are used at the same time.
- This variable is used to control whether the Join Method hint, such as [`HASH_JOIN()` hint](/optimizer-hints.md#hash_joint1_name--tl_name-) and [`MERGE_JOIN()` hint](/optimizer-hints.md#merge_joint1_name--tl_name-), affects the Join Reorder optimization process, including the use of [`LEADING()` hint](/optimizer-hints.md#leadingt1_name--tl_name-). The default value is `ON`, which means that it does not affect. If it is set to `OFF`, there might be conflicts in some scenarios where both Join Method hint and `LEADING()` hint are used at the same time.

> **Note:**
>
> The behavior of versions earlier than v7.0.0 is consistent with that of setting this variable to `OFF`. To ensure forward compatibility, when you upgrade from an earlier version to a v7.0.0 or later cluster, this variable is set to `OFF`. To obtain more flexible Hint behavior, it is strongly recommended to switch this variable to `ON` under the condition that there is no performance regression.
> The behavior of versions earlier than v7.0.0 is consistent with that of setting this variable to `OFF`. To ensure forward compatibility, when you upgrade from an earlier version to a v7.0.0 or later cluster, this variable is set to `OFF`. To obtain more flexible hint behavior, it is strongly recommended to switch this variable to `ON` under the condition that there is no performance regression.
### tidb_opt_insubq_to_join_and_agg

Expand Down

0 comments on commit c020151

Please sign in to comment.