Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: rename three br docs under maintain for better search experience #10029

Merged
merged 2 commits into from Aug 17, 2022
Merged

br: rename three br docs under maintain for better search experience #10029

merged 2 commits into from Aug 17, 2022

Conversation

shichun-0415
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 17, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 17, 2022
@shichun-0415 shichun-0415 added type/enhancement This issue/PR improves documentation usability or supplements document content. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 and removed missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 17, 2022
Oreoxmt
Oreoxmt reviewed Aug 17, 2022
View reviewed changes
TOC.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@shichun-0415 @Oreoxmt
Update TOC.md
51b4dd1 
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 17, 2022
Oreoxmt
Oreoxmt approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2022
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@shichun-0415: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@shichun-0415 shichun-0415 added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 17, 2022
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 51b4dd1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 17, 2022
@ti-chi-bot ti-chi-bot merged commit df52c19 into pingcap:master Aug 17, 2022
@shichun-0415 shichun-0415 deleted the br-docs-under-maintain branch August 17, 2022 09:37
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 17, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10032.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10033.

This was referenced Aug 17, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10034.

ti-chi-bot added a commit that referenced this pull request Aug 17, 2022
@ti-chi-bot
br: rename three br docs under maintain for better search experience (#…
126f282 
…10029) (#10032)
ti-chi-bot added a commit that referenced this pull request Aug 17, 2022
@ti-chi-bot
br: rename three br docs under maintain for better search experience (#…
40b5615 
…10029) (#10033)
ti-chi-bot added a commit that referenced this pull request Aug 17, 2022
@ti-chi-bot
br: rename three br docs under maintain for better search experience (#…
196d739 
…10029) (#10034)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees
No one assigned
Labels
area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shichun-0415 @ti-chi-bot @Oreoxmt