Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tikv docs for titan fallback #10257

Merged
merged 6 commits into from Sep 14, 2022
Merged

update tikv docs for titan fallback #10257

merged 6 commits into from Sep 14, 2022

Conversation

tabokie
Copy link
Contributor

@tabokie tabokie commented Aug 29, 2022 •
edited

Signed-off-by: tabokie xy.tao@outlook.com

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@tabokie
update config for 6.3
07911f2 
Signed-off-by: tabokie <xy.tao@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 29, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 29, 2022
@shichun-0415 shichun-0415 added translation/doing This PR's assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.3 This PR/issue applies to TiDB v6.3. and removed missing-translation-status This PR does not have translation status info. labels Aug 29, 2022
@shichun-0415 shichun-0415 requested review from ran-huang and removed request for shichun-0415 August 31, 2022 14:34
@ran-huang ran-huang added the area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. label Sep 1, 2022
@ran-huang
Copy link
Contributor

@tabokie Could you please involve a technical reviewer?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 5, 2022
@ran-huang ran-huang mentioned this pull request Sep 5, 2022
Merged
12 tasks
@tabokie
update the steps to disable titan
a56c88d 
Signed-off-by: tabokie <xy.tao@outlook.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2022
Connor1996
Connor1996 approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ran-huang
ran-huang reviewed Sep 6, 2022
View reviewed changes
storage-engine/titan-configuration.md Outdated Show resolved Hide resolved
storage-engine/titan-configuration.md Outdated Show resolved Hide resolved
storage-engine/titan-configuration.md Outdated Show resolved Hide resolved
storage-engine/titan-configuration.md Outdated
tikv-ctl --pd <PD_ADDR> compact-cluster --bottommost force
```

+ After the compaction is finished, you should wait for the "Blob file count" metrics under "TiKV-Details/Titan - kv" to decrease to `0`.
Copy link
Contributor

@ran-huang ran-huang Sep 6, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this document, the name of the monitoring panel is "Titan - All", rather than "Titan - kv". Can you confirm which is correct? @tabokie

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's dynamically named. When titan is enabled, it will be "Titan - kv".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks.

@tabokie @ran-huang
Apply suggestions from code review
81936ed 
Co-authored-by: Ran <huangran.alex@gmail.com>
@tabokie
Copy link
Contributor Author

tabokie commented Sep 6, 2022 •
edited

DNM until tikv/tikv#11969 is merged.

@ran-huang ran-huang added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed translation/doing This PR's assignee is translating this PR. labels Sep 6, 2022
@ran-huang ran-huang added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Sep 8, 2022
Oreoxmt
Oreoxmt approved these changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tikv-configuration-file.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 9, 2022
@ran-huang @Oreoxmt
Update tikv-configuration-file.md
a10b5b0 
Co-authored-by: Aolin <aolinz@outlook.com>
tabokie
tabokie commented Sep 14, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
@tabokie tabokie changed the title update tikv docs for read limiter and titan fallback update tikv docs for titan fallback Sep 14, 2022
@tabokie tabokie removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@ran-huang ran-huang added for-future-release This PR only applies to master for now and might cherry-pick to a future release. and removed v6.3 This PR/issue applies to TiDB v6.3. labels Sep 14, 2022
@shichun-0415 shichun-0415 added v6.3 This PR/issue applies to TiDB v6.3. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Sep 14, 2022
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 91f0b2d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 14, 2022
@ti-chi-bot ti-chi-bot merged commit 882d523 into pingcap:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@ran-huang ran-huang

Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.3 This PR/issue applies to TiDB v6.3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tabokie @ti-chi-bot @ran-huang @Connor1996 @Oreoxmt @shichun-0415