Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for raft-engine log recycling feature. #10258

Merged
merged 6 commits into from Sep 6, 2022
Merged

Add docs for raft-engine log recycling feature. #10258

merged 6 commits into from Sep 6, 2022

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Aug 29, 2022 •
edited

Signed-off-by: Lucasliang nkcs_lykx@hotmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add necessary docs for the new feature log recycling in raft-engine, released in v6.3.0.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

None.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@LykxSassinator
Add docs for raft-engine log recycling feature.
ecff587 
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 29, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Aug 29, 2022
@CLAassistant
Copy link

CLAassistant commented Aug 29, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 29, 2022
@LykxSassinator
Copy link
Contributor Author

cc @tabokie PTAL, thx

tabokie
tabokie reviewed Aug 29, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
@LykxSassinator
Remove redundant descriptions.
3be2e0e 
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
@shichun-0415 shichun-0415 added type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.3 This PR/issue applies to TiDB v6.3. translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 29, 2022
@tabokie tabokie mentioned this pull request Aug 30, 2022
Merged
@shichun-0415 shichun-0415 requested review from ran-huang and removed request for shichun-0415 August 31, 2022 14:31
ran-huang
ran-huang reviewed Sep 1, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
@ran-huang ran-huang added the area/raft Indicates that the Issue or PR belongs to the area of Raft. label Sep 1, 2022
@LykxSassinator
Refine the docs on format-version and enable-log-recycle settings.
24c8ef1 
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
ran-huang
ran-huang approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 5, 2022
@LykxSassinator
Refine annoatations on enable-log-recycle.
625019b 
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
ran-huang
ran-huang reviewed Sep 6, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
@ran-huang ran-huang mentioned this pull request Sep 6, 2022
Merged
12 tasks
@LykxSassinator
Tidy annotations.
f5d6e5d 
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
Oreoxmt
Oreoxmt approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tikv-configuration-file.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 6, 2022
@LykxSassinator
Refine style of annotations.
8cbcd70 
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8cbcd70

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2022
@ti-chi-bot ti-chi-bot merged commit e599bbf into pingcap:master Sep 6, 2022
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Sep 6, 2022
@LykxSassinator LykxSassinator deleted the release-log-recycle branch September 6, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@tabokie tabokie tabokie approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@ran-huang ran-huang

Labels
area/raft Indicates that the Issue or PR belongs to the area of Raft. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.3 This PR/issue applies to TiDB v6.3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@LykxSassinator @ti-chi-bot @CLAassistant @ran-huang @tabokie @Oreoxmt @shichun-0415