Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAQ: add a faq (blacklist a sql execution) #10271

Merged
merged 3 commits into from Sep 2, 2022
Merged

FAQ: add a faq (blacklist a sql execution) #10271

merged 3 commits into from Sep 2, 2022

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

FAQ: add a faq (blacklist a sql execution)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 30, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lilin90

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 30, 2022
@TomShawn TomShawn requested review from lilin90 and songrijie and removed request for shichun-0415 August 30, 2022 12:02
@TomShawn TomShawn self-assigned this Aug 30, 2022
@TomShawn TomShawn added type/enhancement This issue/PR improves documentation usability or supplements document content. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 and removed missing-translation-status This PR does not have translation status info. labels Aug 30, 2022
@songrijie
Copy link
Contributor

LGTM

lilin90
lilin90 approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 2, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Sep 2, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 2, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Sep 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4313e4f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 2, 2022
@TomShawn TomShawn merged commit 97581c1 into pingcap:master Sep 2, 2022
@TomShawn TomShawn deleted the add-a-tidb-faq-sql branch September 2, 2022 03:54
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10312.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 2, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 2, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10313.

TomShawn added a commit that referenced this pull request Sep 2, 2022
@ti-chi-bot @TomShawn
FAQ: add a faq (blacklist a sql execution) (#10271) (#10312)
c8ddbef 
* FAQ: add a faq (blacklist a sql execution)

* Update sql-faq.md

* Update sql-faq.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Sep 2, 2022
@ti-chi-bot @TomShawn
FAQ: add a faq (blacklist a sql execution) (#10271) (#10313)
287e183 
* FAQ: add a faq (blacklist a sql execution)

* Update sql-faq.md

* Update sql-faq.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@yahonda
Copy link
Member

yahonda commented Sep 2, 2022

It would be appreciated to use denylist instead. Refer to https://twitter.com/TwitterEng/status/1278733305190342656

@TomShawn TomShawn mentioned this pull request Sep 2, 2022
Merged
12 tasks
@TomShawn
Copy link
Contributor Author

TomShawn commented Sep 2, 2022 •
edited

It would be appreciated to use denylist instead. Refer to https://twitter.com/TwitterEng/status/1278733305190342656

Thanks for reminding me and the recommendation. I prefer deleting the word. See #10315.

This was referenced Sep 2, 2022
Merged
Merged
@TomShawn TomShawn mentioned this pull request Jan 6, 2023
Merged
14 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jan 6, 2023
This was referenced Jan 6, 2023
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@songrijie songrijie Awaiting requested review from songrijie

Assignees

@TomShawn TomShawn

Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TomShawn @ti-chi-bot @songrijie @yahonda @lilin90