Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TiDB support for different OS systems #10292

Closed
wants to merge 3 commits into from

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Sep 1, 2022

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 1, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@TomShawn TomShawn requested review from lilin90 and removed request for shichun-0415 September 1, 2022 03:40
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 1, 2022
@TomShawn TomShawn added needs-cherry-pick-release-6.2 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. area/deploy-upgrade-maintain Indicates that the Issue or PR belongs to the area of deployment, upgrade, and maintenance. and removed missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 1, 2022
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 1, 2022
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be "8.x"? Rest LGTM.

hardware-and-software-requirements.md Outdated Show resolved Hide resolved
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@TomShawn
Copy link
Contributor Author

TomShawn commented Sep 1, 2022

/verify

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2022
@@ -24,11 +24,22 @@ As an open source distributed NewSQL database with high performance, TiDB can be
> - A large number of TiDB tests have been run on the CentOS 7.3 system, and in our community there are a lot of best practices in which TiDB is deployed on the Linux operating system. Therefore, it is recommended to deploy TiDB on CentOS 7.3 or later.
> - The support for the Linux operating systems above includes the deployment and operation in physical servers as well as in major virtualized environments like VMware, KVM and XEN.
> - Red Hat Enterprise Linux 8.0, CentOS 8 Stream, and Oracle Enterprise Linux 8.0 are not supported yet as the testing of these platforms is in progress.
> - Support for CentOS 8 Linux is not planned because its upstream support ends on December 31, 2021.
> - According to [CentOS Linux EOL](https://www.centos.org/centos-linux-eol/), the upstream support for CentOS ended on December 31, 2021.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> - According to [CentOS Linux EOL](https://www.centos.org/centos-linux-eol/), the upstream support for CentOS ended on December 31, 2021.
> - According to [CentOS Linux EOL](https://www.centos.org/centos-linux-eol/), the upstream support for CentOS Linux 8 ended on December 31, 2021. CentOS Stream 8 and CentOS Linux 7 continues to be supported.

See also #10310

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CentOS 8 and CentOS 7 are not verified by the QA team. We will add them here after the QA team has done the test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> - According to [CentOS Linux EOL](https://www.centos.org/centos-linux-eol/), the upstream support for CentOS ended on December 31, 2021.
> - According to [CentOS Linux EOL](https://www.centos.org/centos-linux-eol/), the upstream support for CentOS Linux 8 ended on December 31, 2021. CentOS Linux 7 continues to be supported. We plan to support CentOS Stream 8 once testing has been completed.
  • The text was unclear about the fact that the EOL is only for CentOS Linux 8. CentOS 7 continues to be supported upstream ( see https://wiki.centos.org/About/Product ).
  • This text is talking about upstream support for the OS, which directly influences support for TiDB as supporting TiDB on a OS that no longer has upstream support is a bad idea.
  • We do support CentOS 7
  • Support for TiDB on CentOS Stream 8 depends on testing by the QA team.

| CentOS | 7.3 or later 7.x releases |
| Oracle Enterprise Linux | 7.3 or later 7.x releases |
| Red Hat Enterprise Linux | 7.3 or later 7.x versions, 8.4 or later 8.x versions |
| CentOS | 7.3 or later 7.x versions, 8.4 or later 8.x versions |
Copy link
Contributor

@dveeden dveeden Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| CentOS | 7.3 or later 7.x versions, 8.4 or later 8.x versions |
| CentOS Linux | 7.3 or later 7.x versions |
| CentOS Stream | 8 |

RHEL has versions, CentOS Stream 8 doesn't as it is a rolling release now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dveeden According to the QA team, the Stream 8 is verified only in TiDB v6.1.x and not in v6.2 or v6.3. Therefore, I add it in https://github.com/pingcap/docs/pull/10595/files#diff-d794b834a513233d979186ee859a99d50e5ea7679598b84aeaab0aea12739a7bR22. PTAL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| CentOS | 7.3 or later 7.x versions, 8.4 or later 8.x versions |
| CentOS | 7.3 or later 7.x versions |

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2022
| GCC | 7.x |
| LLVM | 13.0 or later |

Library required for running TiDB: glibc (2.28-151.el8 version)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Library required for running TiDB: glibc (2.28-151.el8 version)
Library required for running TiDB: glibc 2.28

Let's not use a RHEL 8 specific version unless we need to. If we need an exact package version we need to include a matrix that include other operating systems and Linux distributions as well.

@ti-chi-bot
Copy link
Member

@TomShawn: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2022
Copy link

ti-chi-bot bot commented Jan 26, 2024

@TomShawn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify b0e9c12 link true /test pull-verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lilin90
Copy link
Member

lilin90 commented Jan 29, 2024

Since the updates in this PR are outdated and more updates have been merged after this PR is created (for example, #11299), I'll close this PR.

@lilin90 lilin90 closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deploy-upgrade-maintain Indicates that the Issue or PR belongs to the area of deployment, upgrade, and maintenance. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants