-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update TiDB support for different OS systems #10292
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be "8.x"? Rest LGTM.
Co-authored-by: Lilian Lee <lilin@pingcap.com>
/verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -24,11 +24,22 @@ As an open source distributed NewSQL database with high performance, TiDB can be | |||
> - A large number of TiDB tests have been run on the CentOS 7.3 system, and in our community there are a lot of best practices in which TiDB is deployed on the Linux operating system. Therefore, it is recommended to deploy TiDB on CentOS 7.3 or later. | |||
> - The support for the Linux operating systems above includes the deployment and operation in physical servers as well as in major virtualized environments like VMware, KVM and XEN. | |||
> - Red Hat Enterprise Linux 8.0, CentOS 8 Stream, and Oracle Enterprise Linux 8.0 are not supported yet as the testing of these platforms is in progress. | |||
> - Support for CentOS 8 Linux is not planned because its upstream support ends on December 31, 2021. | |||
> - According to [CentOS Linux EOL](https://www.centos.org/centos-linux-eol/), the upstream support for CentOS ended on December 31, 2021. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> - According to [CentOS Linux EOL](https://www.centos.org/centos-linux-eol/), the upstream support for CentOS ended on December 31, 2021. | |
> - According to [CentOS Linux EOL](https://www.centos.org/centos-linux-eol/), the upstream support for CentOS Linux 8 ended on December 31, 2021. CentOS Stream 8 and CentOS Linux 7 continues to be supported. |
See also #10310
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CentOS 8 and CentOS 7 are not verified by the QA team. We will add them here after the QA team has done the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> - According to [CentOS Linux EOL](https://www.centos.org/centos-linux-eol/), the upstream support for CentOS ended on December 31, 2021. | |
> - According to [CentOS Linux EOL](https://www.centos.org/centos-linux-eol/), the upstream support for CentOS Linux 8 ended on December 31, 2021. CentOS Linux 7 continues to be supported. We plan to support CentOS Stream 8 once testing has been completed. |
- The text was unclear about the fact that the EOL is only for CentOS Linux 8. CentOS 7 continues to be supported upstream ( see https://wiki.centos.org/About/Product ).
- This text is talking about upstream support for the OS, which directly influences support for TiDB as supporting TiDB on a OS that no longer has upstream support is a bad idea.
- We do support CentOS 7
- Support for TiDB on CentOS Stream 8 depends on testing by the QA team.
| CentOS | 7.3 or later 7.x releases | | ||
| Oracle Enterprise Linux | 7.3 or later 7.x releases | | ||
| Red Hat Enterprise Linux | 7.3 or later 7.x versions, 8.4 or later 8.x versions | | ||
| CentOS | 7.3 or later 7.x versions, 8.4 or later 8.x versions | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| CentOS | 7.3 or later 7.x versions, 8.4 or later 8.x versions | | |
| CentOS Linux | 7.3 or later 7.x versions | | |
| CentOS Stream | 8 | |
RHEL has versions, CentOS Stream 8 doesn't as it is a rolling release now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dveeden According to the QA team, the Stream 8 is verified only in TiDB v6.1.x and not in v6.2 or v6.3. Therefore, I add it in https://github.com/pingcap/docs/pull/10595/files#diff-d794b834a513233d979186ee859a99d50e5ea7679598b84aeaab0aea12739a7bR22. PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| CentOS | 7.3 or later 7.x versions, 8.4 or later 8.x versions | | |
| CentOS | 7.3 or later 7.x versions | |
| GCC | 7.x | | ||
| LLVM | 13.0 or later | | ||
|
||
Library required for running TiDB: glibc (2.28-151.el8 version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Library required for running TiDB: glibc (2.28-151.el8 version) | |
Library required for running TiDB: glibc 2.28 |
Let's not use a RHEL 8 specific version unless we need to. If we need an exact package version we need to include a matrix that include other operating systems and Linux distributions as well.
@TomShawn: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@TomShawn: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Since the updates in this PR are outdated and more updates have been merged after this PR is created (for example, #11299), I'll close this PR. |
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?