Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs:Add tidb_opt_force_inline_cte system vars usage description in docs. #10343

Merged
merged 7 commits into from Sep 19, 2022
Merged

docs:Add tidb_opt_force_inline_cte system vars usage description in docs. #10343

merged 7 commits into from Sep 19, 2022

Conversation

elsa0520
Copy link
Contributor

@elsa0520 elsa0520 commented Sep 5, 2022 •
edited by shichun-0415

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add tidb_opt_inline_cte system vars usage description in docs

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 5, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added contribution Indicates that the PR was contributed by an external member. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Sep 5, 2022
@ti-chi-bot
Copy link
Member

Welcome @elsa0520!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2022
@shichun-0415 shichun-0415 added for-future-release This PR only applies to master for now and might cherry-pick to a future release. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 5, 2022
@elsa0520 elsa0520 changed the title docs:Add tidb_opt_inline_cte system vars usage description in docs. docs:Add tidb_opt_force_inline_cte system vars usage description in docs. Sep 7, 2022
shichun-0415
shichun-0415 reviewed Sep 9, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@shichun-0415 shichun-0415 added v6.3 This PR/issue applies to TiDB v6.3. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Sep 9, 2022
@shichun-0415 shichun-0415 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed translation/doing This PR's assignee is translating this PR. labels Sep 9, 2022
shichun-0415
shichun-0415 reviewed Sep 9, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2022
fixdb
fixdb reviewed Sep 16, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
shichun-0415
shichun-0415 reviewed Sep 16, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@elsa0520 @shichun-0415
Update system-variables.md
8aef18a 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
fixdb
fixdb reviewed Sep 16, 2022
View reviewed changes
system-variables.md Outdated
- Persists to cluster: Yes
- Type: Boolean
- Default value: `OFF`
- This variable is used to control whether CTEs in the entire session are inlined or not. The default value is `OFF`, which means that inlining CTE is not enforced by default. However, you can still inline CTE by specifying `MERGE() hint`. If the variable is set to `ON`, all CTEs (except recursive CTE) for this session are forced to be inlined.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MERGE() hint
->
MERGE() hint

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 41d6348

shichun-0415
shichun-0415 reviewed Sep 17, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
fixdb
fixdb approved these changes Sep 18, 2022
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

TomShawn
TomShawn reviewed Sep 19, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 19, 2022
@shichun-0415 @TomShawn
Update system-variables.md
35fc8c4 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 35fc8c4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 19, 2022
@ti-chi-bot ti-chi-bot merged commit 76e8001 into pingcap:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@fixdb fixdb fixdb approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
contribution Indicates that the PR was contributed by an external member. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.3 This PR/issue applies to TiDB v6.3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@elsa0520 @ti-chi-bot @CLAassistant @shichun-0415 @fixdb @TomShawn