Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] third party tools update #10384

Merged
merged 7 commits into from Sep 14, 2022

Conversation

Icemap
Copy link
Member

@Icemap Icemap commented Sep 8, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Icemap Icemap added translation/no-need No need to translate this PR. area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 labels Sep 8, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • dveeden

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 8, 2022
@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. ONCALL Relates to documentation oncall. and removed translation/no-need No need to translate this PR. labels Sep 9, 2022
@Oreoxmt Oreoxmt requested review from TomShawn, Oreoxmt and dveeden and removed request for shichun-0415 September 9, 2022 05:40
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

develop/dev-guide-third-party-support.md Outdated Show resolved Hide resolved
develop/dev-guide-third-party-support.md Outdated Show resolved Hide resolved
develop/dev-guide-third-party-support.md Outdated Show resolved Hide resolved
Co-authored-by: Aolin <aolinz@outlook.com>
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 9, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Sep 9, 2022

@TomShawn @dveeden PTAL

Copy link
Contributor

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would strongly suggest to change this:
"TiDB is highly compatible with the MySQL 5.7 protocol,"

to this:
"TiDB is highly compatible with the MySQL protocol,"

  • The actual protocol is version 10 of the MySQL protocol. However the version number is largely meaningless as it has been used for many years and there are many protocol extensions added since then.
  • We are compatible with most of the MySQL 5.7 syntax. This is more important than compatibility with just the protocol.
  • We are already support quite a bit of MySQL 8.0 syntax and features.
  • We should use the "MySQL Compatibility" page to describe compatibility details instead.

develop/dev-guide-third-party-support.md Outdated Show resolved Hide resolved
develop/dev-guide-third-party-support.md Outdated Show resolved Hide resolved
develop/dev-guide-third-party-support.md Outdated Show resolved Hide resolved
develop/dev-guide-third-party-support.md Show resolved Hide resolved
Icemap and others added 4 commits September 13, 2022 17:20
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 13, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Sep 13, 2022

/verify

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Sep 14, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c4145c1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 14, 2022
@ti-chi-bot ti-chi-bot merged commit 90c5f9e into pingcap:master Sep 14, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10415.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10416.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. ONCALL Relates to documentation oncall. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants