New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Update] third party tools update #10384
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Co-authored-by: Aolin <aolinz@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would strongly suggest to change this:
"TiDB is highly compatible with the MySQL 5.7 protocol,"
to this:
"TiDB is highly compatible with the MySQL protocol,"
- The actual protocol is version 10 of the MySQL protocol. However the version number is largely meaningless as it has been used for many years and there are many protocol extensions added since then.
- We are compatible with most of the MySQL 5.7 syntax. This is more important than compatibility with just the protocol.
- We are already support quite a bit of MySQL 8.0 syntax and features.
- We should use the "MySQL Compatibility" page to describe compatibility details instead.
Co-authored-by: Daniël van Eeden <github@myname.nl>
Co-authored-by: Daniël van Eeden <github@myname.nl>
… feat-third-party-reform
/verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c4145c1
|
In response to a cherrypick label: new pull request created: #10415. |
In response to a cherrypick label: new pull request created: #10416. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?