Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pitr: added newer pitr & tiflash adapt information #10406

Merged
merged 2 commits into from Sep 19, 2022
Merged

pitr: added newer pitr & tiflash adapt information #10406

merged 2 commits into from Sep 19, 2022

Conversation

shichun-0415
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 13, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2022
@shichun-0415 shichun-0415 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). v6.3 This PR/issue applies to TiDB v6.3. and removed missing-translation-status This PR does not have translation status info. labels Sep 13, 2022
TomShawn
TomShawn reviewed Sep 16, 2022
View reviewed changes
br/pitr-troubleshoot.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Sep 16, 2022
View reviewed changes
br/pitr-troubleshoot.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2022
@shichun-0415 @TomShawn
Apply suggestions from code review
baa4459 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@shichun-0415
Copy link
Contributor Author

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 19, 2022
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: baa4459

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 19, 2022
@ti-chi-bot ti-chi-bot merged commit 558b32e into pingcap:master Sep 19, 2022
@shichun-0415 shichun-0415 deleted the pitr-for-tiflash branch September 19, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.3 This PR/issue applies to TiDB v6.3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shichun-0415 @ti-chi-bot @YuJuncen @TomShawn