Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system-variable: add document for tx_isolation_one_shot #10566

Merged
merged 4 commits into from Oct 11, 2022
Merged

system-variable: add document for tx_isolation_one_shot #10566

merged 4 commits into from Oct 11, 2022

Conversation

tiancaiamao
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 27, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2022
@tiancaiamao
Copy link
Contributor Author

PTAL @bb7133

@shichun-0415 shichun-0415 added translation/doing This PR's assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. add-missing-docs Add missing system variables to documentation and removed missing-translation-status This PR does not have translation status info. labels Sep 29, 2022
TomShawn
TomShawn reviewed Sep 29, 2022
View reviewed changes
system-variables.md Outdated
@@ -2319,6 +2319,12 @@ Query OK, 0 rows affected, 1 warning (0.00 sec)

This variable is an alias for `transaction_isolation`.

### tx_isolation_one_shot

This variable is an internal system variable, not meant to be used directly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide the scope, the default value, or type, and the description?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People should not use this variable directly, so why bother for more details?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(For some historial reasons) It's a special one, not like the other variables...

TomShawn
TomShawn reviewed Oct 8, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Oct 8, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
tiancaiamao and others added 2 commits October 9, 2022 09:54
@tiancaiamao @TomShawn
Update system-variables.md
edccf5e 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@tiancaiamao @TomShawn
Update system-variables.md
29768bf 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Oct 9, 2022
TomShawn
TomShawn reviewed Oct 9, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2022
@TomShawn TomShawn removed the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Oct 9, 2022
@TomShawn TomShawn self-assigned this Oct 9, 2022
bb7133
bb7133 approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 11, 2022
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c7040c4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 11, 2022
@ti-chi-bot ti-chi-bot merged commit 44bc9e2 into pingcap:master Oct 11, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10725.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10726.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10727.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
13 tasks
ti-chi-bot added a commit that referenced this pull request Oct 12, 2022
@ti-chi-bot
system-variable: add document for tx_isolation_one_shot (#10566) (#10727
4a96513 
)
ti-chi-bot added a commit that referenced this pull request Oct 12, 2022
@ti-chi-bot
system-variable: add document for tx_isolation_one_shot (#10566) (#10726
68e6fbb 
)
ti-chi-bot added a commit that referenced this pull request Oct 12, 2022
@ti-chi-bot
system-variable: add document for tx_isolation_one_shot (#10566) (#10725
b3c8ae9 
)
@TomShawn TomShawn mentioned this pull request Oct 13, 2022
Merged
13 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Oct 13, 2022
This was referenced Oct 14, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@TomShawn TomShawn TomShawn approved these changes

@shichun-0415 shichun-0415 Awaiting requested review from shichun-0415

Assignees

@TomShawn TomShawn

Labels
add-missing-docs Add missing system variables to documentation needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tiancaiamao @ti-chi-bot @TomShawn @bb7133 @hawkingrei @shichun-0415