Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tiflash-overview.md #10635

Merged
merged 3 commits into from Jan 18, 2023
Merged

Update tiflash-overview.md #10635

merged 3 commits into from Jan 18, 2023

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Oct 8, 2022 •
edited by shichun-0415

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add the description that to deploy TiFlash under the Linux AMD64 architecture, the CPU must support AVX2 instruction sets

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 8, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2022
This was referenced Oct 8, 2022
Closed
Closed
zanmato1984
zanmato1984 approved these changes Oct 8, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shichun-0415 shichun-0415 added type/enhancement This issue/PR improves documentation usability or supplements document content. translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-6.3 and removed missing-translation-status This PR does not have translation status info. labels Oct 8, 2022
@shichun-0415 shichun-0415 self-assigned this Oct 8, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Oct 9, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2022
solotzg
solotzg commented Oct 9, 2022
View reviewed changes
tiflash/tiflash-overview.md Outdated Show resolved Hide resolved
@shichun-0415 shichun-0415 added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Dec 30, 2022
@JaySon-Huang
Copy link
Contributor

@solotzg we should add the "AVX2" requirements in this doc
https://docs.pingcap.com/tidb/stable/hardware-and-software-requirements#os-and-platform-requirements

@solotzg
Copy link
Contributor Author

solotzg commented Jan 18, 2023

@solotzg we should add the "AVX2" requirements in this doc https://docs.pingcap.com/tidb/stable/hardware-and-software-requirements#os-and-platform-requirements

There is already a PR pingcap/docs-cn#11501 several months ago.

@shichun-0415 shichun-0415 removed the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jan 18, 2023
shichun-0415
shichun-0415 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 18, 2023
@shichun-0415 shichun-0415 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2023
@shichun-0415
Copy link
Contributor

/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 18, 2023
@solotzg
Copy link
Contributor Author

solotzg commented Jan 18, 2023

/merge

@ti-chi-bot
Copy link
Member

@solotzg: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0966335

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2023
@shichun-0415 shichun-0415 merged commit dcc0684 into master Jan 18, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 18, 2023
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12142.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 18, 2023
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.3: #12143.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 18, 2023
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #12144.

@shichun-0415 shichun-0415 mentioned this pull request Jan 18, 2023
Merged
15 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jan 18, 2023
This was referenced Jan 18, 2023
Merged
Merged
Merged
ti-chi-bot added a commit that referenced this pull request Jan 18, 2023
@ti-chi-bot
Update tiflash-overview.md (#10635) (#12144)
fdd14be
ti-chi-bot added a commit that referenced this pull request Jan 18, 2023
@ti-chi-bot
Update tiflash-overview.md (#10635) (#12143)
11c4a25
ti-chi-bot added a commit that referenced this pull request Jan 18, 2023
@ti-chi-bot
Update tiflash-overview.md (#10635) (#12142)
4a2595e
Oreoxmt pushed a commit to Oreoxmt/docs that referenced this pull request Jan 29, 2023
@solotzg @Oreoxmt
Update tiflash-overview.md (pingcap#10635)
8a0d30d 
* Update tiflash-overview.md

* Update tiflash-overview.md

* Update tiflash/tiflash-overview.md

Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@shichun-0415 shichun-0415 deleted the solotzg-patch-3 branch February 2, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@windtalker windtalker Awaiting requested review from windtalker

Assignees

@shichun-0415 shichun-0415

Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@solotzg @ti-chi-bot @JaySon-Huang @shichun-0415 @zanmato1984