Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config, sysvar: update descriptions about instance sysvars #10910

Merged
merged 15 commits into from Nov 2, 2022
Merged

config, sysvar: update descriptions about instance sysvars #10910

merged 15 commits into from Nov 2, 2022

Conversation

CbcWestwolf
Copy link
Member

@CbcWestwolf CbcWestwolf commented Oct 19, 2022 •
edited by TomShawn

What is changed, added or deleted? (Required)

Change descriptions about instance system variables and [instance] config items.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 19, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CbcWestwolf CbcWestwolf requested review from TomShawn and removed request for shichun-0415 October 19, 2022 09:49
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 19, 2022
@qiancai qiancai added the v6.4 This PR/issue applies to TiDB v6.4. label Oct 19, 2022
@TomShawn TomShawn removed their assignment Oct 19, 2022
@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. for-release This PR relates to a TiDB release but does not have a tracked feature. and removed missing-translation-status This PR does not have translation status info. labels Oct 19, 2022
@qiancai qiancai added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. and removed translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. for-release This PR relates to a TiDB release but does not have a tracked feature. labels Oct 19, 2022
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Oct 19, 2022
@qiancai qiancai added the for-release This PR relates to a TiDB release but does not have a tracked feature. label Oct 19, 2022
@qiancai qiancai added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Oct 19, 2022
@TomShawn TomShawn removed the missing-translation-status This PR does not have translation status info. label Oct 19, 2022
@CbcWestwolf
Copy link
Member Author

/vale

@TomShawn TomShawn added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Oct 19, 2022
TomShawn
TomShawn reviewed Oct 20, 2022
View reviewed changes
character-set-and-collation.md Outdated Show resolved Hide resolved
configure-memory-usage.md Outdated Show resolved Hide resolved
configure-memory-usage.md Outdated Show resolved Hide resolved
faq/manage-cluster-faq.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
CbcWestwolf and others added 3 commits October 20, 2022 17:30
@CbcWestwolf @TomShawn
Apply suggestions from code review
a04dace 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@CbcWestwolf @TomShawn
Update character-set-and-collation.md
fca03a2 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@CbcWestwolf
Update
9d0102d
@TomShawn TomShawn added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 and removed v6.4 This PR/issue applies to TiDB v6.4. for-release This PR relates to a TiDB release but does not have a tracked feature. labels Nov 1, 2022
bb7133
bb7133 approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hfxsd
hfxsd reviewed Nov 1, 2022
View reviewed changes
character-set-and-collation.md Outdated Show resolved Hide resolved
configure-memory-usage.md Outdated Show resolved Hide resolved
configure-memory-usage.md Outdated Show resolved Hide resolved
dashboard/dashboard-slow-query.md Outdated Show resolved Hide resolved
explain-joins.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-topology-reference.md Show resolved Hide resolved
TomShawn and others added 2 commits November 1, 2022 14:49
@TomShawn @hfxsd
Apply suggestions from code review
10babd0 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@TomShawn @hfxsd
Update character-set-and-collation.md
b303525 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
TomShawn
TomShawn reviewed Nov 1, 2022
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
@TomShawn TomShawn requested a review from hfxsd November 1, 2022 11:09
hfxsd
hfxsd approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

system-variables.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 2, 2022
@CbcWestwolf @hfxsd
Apply suggestions from code review
fe9d87b 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@TomShawn
Copy link
Contributor

TomShawn commented Nov 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fe9d87b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2022
@ti-chi-bot ti-chi-bot merged commit d136779 into pingcap:master Nov 2, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 2, 2022
Closed
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11126.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 2, 2022
@CbcWestwolf @ti-chi-bot
This is an automated cherry-pick of pingcap#10910
2b80a85 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 2, 2022
Closed
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11127.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 2, 2022
@CbcWestwolf @ti-chi-bot
This is an automated cherry-pick of pingcap#10910
bdb62a4 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 2, 2022
@CbcWestwolf @ti-chi-bot
This is an automated cherry-pick of pingcap#10910
fd61f9e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 2, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11128.

TomShawn added a commit that referenced this pull request Nov 2, 2022
@ti-chi-bot @CbcWestwolf @TomShawn
config, sysvar: update descriptions about instance sysvars (#10910) (#…
9275224 
…11128)

* This is an automated cherry-pick of #10910

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* Update system-variables.md

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Co-authored-by: CbcWestwolf <1004626265@qq.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@bb7133 bb7133 bb7133 approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees

@TomShawn TomShawn

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@CbcWestwolf @ti-chi-bot @TomShawn @bb7133 @hfxsd @lilin90 @qiancai