Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop: fix paging sql with multiple columns for cluster index table #10988

Merged
merged 3 commits into from Oct 25, 2022

Conversation

Mini256
Copy link
Member

@Mini256 Mini256 commented Oct 24, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 24, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Icemap
  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 24, 2022
@Mini256 Mini256 added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Oct 24, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Oct 24, 2022
@Mini256 Mini256 added missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 and removed missing-translation-status This PR does not have translation status info. labels Oct 24, 2022
@Mini256 Mini256 requested a review from Icemap October 24, 2022 17:08
@Oreoxmt Oreoxmt requested review from Oreoxmt and removed request for shichun-0415 October 25, 2022 03:55
@Oreoxmt Oreoxmt added the area/develop This PR relates to the area of TiDB App development. label Oct 25, 2022
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

develop/dev-guide-paginate-results.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 25, 2022
Co-authored-by: Aolin <aolinz@outlook.com>
@Mini256
Copy link
Member Author

Mini256 commented Oct 25, 2022

@Oreoxmt, thanks for your review!

@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Oct 25, 2022
Copy link
Contributor

@Icemap Icemap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

develop/dev-guide-paginate-results.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 25, 2022
Co-authored-by: Cheese <qizhi.wang@pingcap.com>
@Mini256 Mini256 requested a review from winoros October 25, 2022 06:17
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 25, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ad190e8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 25, 2022
@ti-chi-bot ti-chi-bot merged commit 25e24b1 into pingcap:master Oct 25, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10995.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10996.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10997.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants