Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LINEAR HASH/KEY mysql compatibility #11085

Merged
merged 16 commits into from Nov 16, 2022

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Oct 28, 2022

What is changed, added or deleted? (Required)

See pingcap/tidb#38450 where CREATE TABLE ... PARTITION BY LINEAR HASH will now create a non-linear HASH partitioned table instead of a non-partitioned normal table.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2022
@qiancai qiancai added translation/doing This PR's assignee is translating this PR. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. v6.4 This PR/issue applies to TiDB v6.4. labels Oct 30, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Oct 30, 2022
@qiancai qiancai requested a review from moyun November 1, 2022 10:59
@qiancai qiancai self-assigned this Nov 1, 2022
@Oreoxmt Oreoxmt requested review from Oreoxmt and removed request for shichun-0415 November 2, 2022 08:06
@qiancai
Copy link
Collaborator

qiancai commented Nov 2, 2022

@moyun PTAL

Copy link

@moyun moyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to describe PARTITION BY LINEAR HASH in a new paragraph and remove from current "unsupported" list.
We can say that it is a compatible one, but just at grammar level and we create a hash partition instead. User's original DDL/DML on a MySQL Linear Hash table can keep in use without modification.

@mjonss
Copy link
Contributor Author

mjonss commented Nov 2, 2022

I suggest to describe PARTITION BY LINEAR HASH in a new paragraph and remove from current "unsupported" list. We can say that it is a compatible one, but just at grammar level and we create a hash partition instead. User's original DDL/DML on a MySQL Linear Hash table can keep in use without modification.

OK, so a new paragraph in the partitioned-table.md describing how LINEAR HASH is handled (i.e. like non-linear HASH) and only mention LINEAR KEY in the mysql-compatibility.md ?

partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2022
partitioned-table.md Outdated Show resolved Hide resolved
Co-authored-by: Grace Cai <qqzczy@126.com>
partitioned-table.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator

qiancai commented Nov 11, 2022

@moyun Would you please help review the latest updates of this PR? Thanks.

@qiancai qiancai removed the translation/doing This PR's assignee is translating this PR. label Nov 13, 2022
Copy link

@moyun moyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

partitioned-table.md Outdated Show resolved Hide resolved
Co-authored-by: Aolin <aolinz@outlook.com>
partitioned-table.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt self-requested a review November 16, 2022 07:13
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2022
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 16, 2022
partitioned-table.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Co-authored-by: Aolin <aolinz@outlook.com>
partitioned-table.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator

qiancai commented Nov 16, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a78b4fb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 16, 2022
@ti-chi-bot ti-chi-bot merged commit fadbfa6 into pingcap:master Nov 16, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11340.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.4 This PR/issue applies to TiDB v6.4.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants