Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiflash: Add instructions to improve replica sync performance #11398

Merged
merged 4 commits into from Nov 22, 2022
Merged

tiflash: Add instructions to improve replica sync performance #11398

merged 4 commits into from Nov 22, 2022

Conversation

breezewish
Copy link
Member

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add some instructions about how to sync TiFlash replica faster.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@breezewish
tiflash: Add instructions to improve replica sync performance
042d8b0 
Signed-off-by: Wish <breezewish@outlook.com>
@breezewish
grumble
cb54b11 
Signed-off-by: Wish <breezewish@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 22, 2022
@shichun-0415 shichun-0415 added type/enhancement This issue/PR improves documentation usability or supplements document content. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. needs-cherry-pick-release-6.4 and removed missing-translation-status This PR does not have translation status info. labels Nov 22, 2022
shichun-0415
shichun-0415 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM. Great job. Thanks.

tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2022
@breezewish @shichun-0415
Apply suggestions from code review
8c8a8eb 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
qiancai
qiancai reviewed Nov 22, 2022
View reviewed changes
tiflash/create-tiflash-replicas.md Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved
@shichun-0415 @qiancai
Apply suggestions from code review
0514794 
Co-authored-by: Grace Cai <qqzczy@126.com>
@shichun-0415 shichun-0415 added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 22, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0514794

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2022
@ti-chi-bot ti-chi-bot merged commit 180db82 into master Nov 22, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11399.

@shichun-0415 shichun-0415 deleted the wenxuan/faster-tiflash-replica-sync branch November 22, 2022 12:30
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11400.

ti-chi-bot added a commit that referenced this pull request Nov 22, 2022
@ti-chi-bot
tiflash: Add instructions to improve replica sync performance (#11398) (
6559a3f 
#11399)
ti-chi-bot added a commit that referenced this pull request Nov 22, 2022
@ti-chi-bot
tiflash: Add instructions to improve replica sync performance (#11398) (
b81cbb0 
#11400)
@breezewish breezewish mentioned this pull request Nov 22, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai left review comments

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees
No one assigned
Labels
area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@breezewish @ti-chi-bot @shichun-0415 @qiancai