Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tikv-br docs #11506

Merged
merged 8 commits into from Dec 5, 2022
Merged

Add tikv-br docs #11506

merged 8 commits into from Dec 5, 2022

Conversation

haojinming
Copy link
Contributor

@haojinming haojinming commented Dec 2, 2022

Signed-off-by: haojinming jinming.hao@pingcap.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: haojinming <jinming.hao@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Dec 2, 2022
@CLAassistant
Copy link

CLAassistant commented Dec 2, 2022

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2022
@shichun-0415 shichun-0415 added translation/doing This PR's assignee is translating this PR. v6.5 This PR/issue applies to TiDB v6.5. and removed missing-translation-status This PR does not have translation status info. labels Dec 2, 2022
br/rawkv-backup-and-restore.md Outdated Show resolved Hide resolved
br/rawkv-backup-and-restore.md Outdated Show resolved Hide resolved
@shichun-0415
Copy link
Contributor

Could you please help synchronize the change to the Chinese version? Thank you

@haojinming
Copy link
Contributor Author

Could you please help synchronize the change to the Chinese version? Thank you
Chinese docs PR is here:
pingcap/docs-cn#12188 . PTAL~ thanks.

Signed-off-by: haojinming <jinming.hao@pingcap.com>
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Dec 2, 2022
br/rawkv-backup-and-restore.md Outdated Show resolved Hide resolved
br/rawkv-backup-and-restore.md Outdated Show resolved Hide resolved
Signed-off-by: haojinming <jinming.hao@pingcap.com>
@pingyu
Copy link
Contributor

pingyu commented Dec 2, 2022

Suggest to simply as following:

TiKV and PD can constitute a KV database when used without TiDB, which is called RawKV. TiKV-BR supports data backup and restore for products that use RawKV. Please see [TiKV-BR User Docs] for detail.

API v2 is another feature, and in general users use API v2 first, and then they need the BR.
The CDC is also another feature for a different scenario. I think it's not suitable to mention it here.

Signed-off-by: haojinming <jinming.hao@pingcap.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2022
Signed-off-by: haojinming <jinming.hao@pingcap.com>
Signed-off-by: haojinming <jinming.hao@pingcap.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2022
Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 3, 2022
@shichun-0415
Copy link
Contributor

/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 5, 2022
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tikv-configuration-file.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Dec 5, 2022
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a58734c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 5, 2022
@ti-chi-bot ti-chi-bot merged commit b847b0f into pingcap:master Dec 5, 2022
@haojinming haojinming changed the title Add tikv-br link Add tikv-br docs Dec 6, 2022
@qiancai qiancai mentioned this pull request Dec 6, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.5 This PR/issue applies to TiDB v6.5.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants