New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv-control.md: update tikv-control.md for raft region #11526
Conversation
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @HuSharp |
@Oreoxmt: GitHub didn't allow me to request PR reviews from the following users: HuSharp. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tikv-control.md
Outdated
- To limit the number of Regions to be printed, use the `--limit` option (default: `16`). | ||
- To query which Regions are included in a certain key range, use the `--start` and `--end` options (default: no range limit, in Hex format). | ||
|
||
To print the Region with id `1239`, use the following command: | ||
|
||
```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can unify this file ```bash
to the ```shell
🤔
If you don't think it's necessary, we can just change this pr to ```shell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8817dae PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, can you remove all $
to unify? I will do the same in docs-cn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
efe10e7 Done
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
/verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM!
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
/status LGT1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
tikv-control.md
Outdated
To query which Regions are included in a certain key range, use the following command: | ||
|
||
```shell | ||
tikv-ctl --host 127.0.0.1:20160 raft region --start 7480000000000000FF4E5F728000000000FF1443770000000000FA --end 7480000000000000FF4E5F728000000000FF21C4420000000000FA | ||
``` | ||
|
||
- If the key range is in a Region range, the Region information is output. | ||
- If the key range is the same as a Region range, for example, when the given key range is the same as the Region `1239`, because the Region range is a left-closed and right-open interval, and Region `1009` takes the `end_key` of Region `1239` as the `start_key`, the Region `1009` information is also output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order is different from the Chinese version: https://github.com/pingcap/docs-cn/pull/12056/files#diff-ff89854f38035fc717cda9246e345cffc32f58be987165f3529f06b3a4586065R183-R190
@Oreoxmt: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2fcf127
|
Signed-off-by: Aolin aolin.zhang@pingcap.com
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?