Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate ticdc architecture and overview #11574

Merged
merged 13 commits into from
Dec 18, 2022
Merged

translate ticdc architecture and overview #11574

merged 13 commits into from
Dec 18, 2022

Conversation

shichun-0415
Copy link
Contributor

@shichun-0415 shichun-0415 commented Dec 10, 2022 •
edited

First-time contributors' checklist

What is changed, added or deleted? (Required)

Aligns ticdc-architecture and ticdc-overview in pingcap/docs-cn#11849

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 10, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 10, 2022
@shichun-0415 shichun-0415 added type/refactor Reorganizes the documentation structure. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. and removed missing-translation-status This PR does not have translation status info. labels Dec 10, 2022
@shichun-0415 shichun-0415 requested review from nongfushanquan and qiancai and removed request for TomShawn December 12, 2022 11:05
@shichun-0415 @IANTHEREAL
Apply suggestions from code review
3f81202 
Co-authored-by: Ian <ArGregoryIan@gmail.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2022
qiancai
qiancai reviewed Dec 13, 2022
View reviewed changes
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
@shichun-0415 @qiancai @IANTHEREAL
Apply suggestions from code review
eabffc8 
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Ian <ArGregoryIan@gmail.com>
shichun-0415
shichun-0415 commented Dec 16, 2022
View reviewed changes
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
@shichun-0415 @IANTHEREAL
Apply suggestions from code review
edde150 
Co-authored-by: Ian <ArGregoryIan@gmail.com>
qiancai
qiancai reviewed Dec 16, 2022
View reviewed changes
ticdc/ticdc-overview.md Outdated Show resolved Hide resolved
ticdc/ticdc-overview.md Outdated Show resolved Hide resolved
ticdc/ticdc-overview.md Outdated Show resolved Hide resolved
ticdc/ticdc-overview.md Outdated Show resolved Hide resolved
ticdc/ticdc-overview.md Outdated Show resolved Hide resolved
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
ticdc/ticdc-architecture.md Outdated Show resolved Hide resolved
ticdc/ticdc-overview.md Outdated Show resolved Hide resolved
qiancai
qiancai approved these changes Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 16, 2022
shichun-0415 and others added 2 commits December 16, 2022 22:48
@shichun-0415 @qiancai
Apply suggestions from code review
9848d63 
Co-authored-by: Grace Cai <qqzczy@126.com>
@shichun-0415
ci
39e5846
@shichun-0415
Copy link
Contributor Author

/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 18, 2022
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 39e5846

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 18, 2022
@ti-chi-bot ti-chi-bot merged commit 3f4d157 into pingcap:master Dec 18, 2022
@shichun-0415 shichun-0415 deleted the cdc-arhitecture-and-overview branch December 18, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

@qiancai qiancai qiancai approved these changes

@nongfushanquan nongfushanquan Awaiting requested review from nongfushanquan

Assignees
No one assigned
Labels
area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/refactor Reorganizes the documentation structure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shichun-0415 @ti-chi-bot @IANTHEREAL @qiancai