dev/how-to/get-started: Add information about "flavor" setting to data-migration.md #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QueenyJin
reviewed
May 23, 2019
| @@ -227,6 +227,8 @@ password = "" | |||
| port = 3307 | |||
| ``` | |||
|
|
|||
| The `flavor` option should be set to `"mysql"` (the default) if migrating from MySQL Server, Percona Server, Percona XtraDB Cluster, or Amazon Aurora or RDS. If migrating from MariaDB Server or MariaDB (Galera) Cluster, use `flavor = "mariadb"` (only MariaDB versions greater than 10.1.2 are supported). | |||
There was a problem hiding this comment.
How about:
- If you migrate from MySQL Server, Percona Server, Percona XtraDB Cluster, or Amazon Aurora or Amazon RDS to TiDB, use
flavor = "mysql", which is the default option. - If you migrate from MariaDB Server or MariaDB Galera Cluster to TiDB, use
flavor = "mariadb".
** Note: ** DM supports MariaDB versions later than 10.1.2 only.
There was a problem hiding this comment.
I think that's needlessly verbose and confusing, actually. Do you really object so strenuously to the single-paragraph style I used?
CaitinChen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.