Update the command and output in SQL statements #11807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Oreoxmt
added
type/enhancement
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
the
size/XXL
TomShawn
reviewed
Dec 30, 2022
| Query OK, 0 rows affected (0.02 sec) | ||
| ``` | ||
|
|
||
| Jennifer no longer has the default role of analyticsteam associated, or can set the role to analyticsteam: | ||
| `jennifer` no longer has the default role of `analyticsteam` associated, or can set the role to `analyticsteam`. |
There was a problem hiding this comment.
Suggested change
| `jennifer` no longer has the default role of `analyticsteam` associated, or can set the role to `analyticsteam`. | |
| `jennifer` no longer has the default role of `analyticsteam` associated, nor can set the role to `analyticsteam`. |
TomShawn
reviewed
Dec 30, 2022
|
|
||
| Type 'help;' or '\h' for help. Type '\c' to clear the current input statement. | ||
| Note that by default `jennifer` needs to `SET ROLE analyticsteam` in order to be able to use the privileges associated with the `analyticsteam` role: |
There was a problem hiding this comment.
Suggested change
| Note that by default `jennifer` needs to `SET ROLE analyticsteam` in order to be able to use the privileges associated with the `analyticsteam` role: | |
| Note that by default `jennifer` needs to execute `SET ROLE analyticsteam` in order to be able to use the privileges associated with the `analyticsteam` role: |
TomShawn
reviewed
Dec 30, 2022
|
|
||
| Type 'help;' or '\h' for help. Type '\c' to clear the current input statement. | ||
| After this, the user `jennifer` has the privileges associated with the role `analyticsteam` and you do not have to execute the statement `SET ROLE`: |
There was a problem hiding this comment.
Suggested change
| After this, the user `jennifer` has the privileges associated with the role `analyticsteam` and you do not have to execute the statement `SET ROLE`: | |
| After this, the user `jennifer` has the privileges associated with the role `analyticsteam` and `jennifer` does not have to execute the statement `SET ROLE`: |
TomShawn
approved these changes
Dec 30, 2022
|
|
||
| Type 'help;' or '\h' for help. Type '\c' to clear the current input statement. | ||
| Note that by default `jennifer` needs to `SET ROLE analyticsteam` in order to be able to use the privileges associated with the `analyticsteam` role: |
There was a problem hiding this comment.
Suggested change
| Note that by default `jennifer` needs to `SET ROLE analyticsteam` in order to be able to use the privileges associated with the `analyticsteam` role: | |
| Note that by default `jennifer` needs to execute `SET ROLE analyticsteam` in order to be able to use the privileges associated with the `analyticsteam` role: |
|
|
||
| Type 'help;' or '\h' for help. Type '\c' to clear the current input statement. | ||
| After this, the user `jennifer` has the privileges associated with the role `analyticsteam` and you do not have to execute the statement `SET ROLE`: |
There was a problem hiding this comment.
Suggested change
| After this, the user `jennifer` has the privileges associated with the role `analyticsteam` and you do not have to execute the statement `SET ROLE`: | |
| After this, the user `jennifer` has the privileges associated with the role `analyticsteam` and `jennifer` does not have to execute the statement `SET ROLE`: |
|
|
||
| Type 'help;' or '\h' for help. Type '\c' to clear the current input statement. | ||
| Note that by default `jennifer` needs to `SET ROLE analyticsteam` in order to be able to use the privileges associated with the `analyticsteam` role: |
There was a problem hiding this comment.
Suggested change
| Note that by default `jennifer` needs to `SET ROLE analyticsteam` in order to be able to use the privileges associated with the `analyticsteam` role: | |
| Note that by default `jennifer` needs to execute `SET ROLE analyticsteam` in order to be able to use the privileges associated with the `analyticsteam` role: |
|
|
||
| Type 'help;' or '\h' for help. Type '\c' to clear the current input statement. | ||
| After this, the user `jennifer` has the privileges associated with the role `analyticsteam` and you do not have to execute the statement `SET ROLE`: |
There was a problem hiding this comment.
Suggested change
| After this, the user `jennifer` has the privileges associated with the role `analyticsteam` and you do not have to execute the statement `SET ROLE`: | |
| After this, the user `jennifer` has the privileges associated with the role `analyticsteam` and `jennifer` does not have to execute the statement `SET ROLE`: |
|
|
||
| Type 'help;' or '\h' for help. Type '\c' to clear the current input statement. | ||
| Note that by default `jennifer` needs to `SET ROLE analyticsteam` in order to be able to use the privileges associated with the `analyticsteam` role: |
There was a problem hiding this comment.
Suggested change
| Note that by default `jennifer` needs to `SET ROLE analyticsteam` in order to be able to use the privileges associated with the `analyticsteam` role: | |
| Note that by default `jennifer` needs to execute `SET ROLE analyticsteam` in order to be able to use the privileges associated with the `analyticsteam` role: |
|
|
||
| Type 'help;' or '\h' for help. Type '\c' to clear the current input statement. | ||
| After this, the user `jennifer` has the privileges associated with the role `analyticsteam` and you do not have to execute the statement `SET ROLE`: |
There was a problem hiding this comment.
Suggested change
| After this, the user `jennifer` has the privileges associated with the role `analyticsteam` and you do not have to execute the statement `SET ROLE`: | |
| After this, the user `jennifer` has the privileges associated with the role `analyticsteam` and `jennifer` does not have to execute the statement `SET ROLE`: |
|
|
||
| Type 'help;' or '\h' for help. Type '\c' to clear the current input statement. | ||
| Note that by default `jennifer` needs to `SET ROLE analyticsteam` in order to be able to use the privileges associated with the `analyticsteam` role: |
There was a problem hiding this comment.
Suggested change
| Note that by default `jennifer` needs to `SET ROLE analyticsteam` in order to be able to use the privileges associated with the `analyticsteam` role: | |
| Note that by default `jennifer` needs to execute `SET ROLE analyticsteam` in order to be able to use the privileges associated with the `analyticsteam` role: |
|
|
||
| Type 'help;' or '\h' for help. Type '\c' to clear the current input statement. | ||
| After this, the user `jennifer` has the privileges associated with the role `analyticsteam` and you do not have to execute the statement `SET ROLE`: |
There was a problem hiding this comment.
Suggested change
| After this, the user `jennifer` has the privileges associated with the role `analyticsteam` and you do not have to execute the statement `SET ROLE`: | |
| After this, the user `jennifer` has the privileges associated with the role `analyticsteam` and `jennifer` do not have to execute the statement `SET ROLE`: |
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 4b73978
|
ti-chi-bot
added
the
status/can-merge
15 tasks
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
This was referenced Dec 30, 2022
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
added a commit
that referenced
this pull request
Dec 30, 2022
ti-chi-bot
added a commit
that referenced
this pull request
Dec 30, 2022
ti-chi-bot
added a commit
that referenced
this pull request
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aolin aolin.zhang@pingcap.com
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?