Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move external storage to dumpling and lightning docs #12354

Merged

Conversation

shichun-0415
Copy link
Contributor

@shichun-0415 shichun-0415 commented Feb 1, 2023

What is changed, added or deleted? (Required)

After BR refactor in pingcap/docs-cn#11316, external storage is replaced by Backup Storages. However, because some description about Dumpling and Lightning are still be useful and referenced by Dumpling and Lightning docs, external storage is removed from the navigation but kept in the docs repo. It would be better to move information about Dumpling and Lightning to the docs of these two tools, instead of being wrapped in br docs.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 1, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 1, 2023
@shichun-0415 shichun-0415 requested review from Oreoxmt and removed request for TomShawn February 1, 2023 09:07
@shichun-0415 shichun-0415 added type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-6.4 needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Feb 1, 2023
@Oreoxmt Oreoxmt added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Feb 1, 2023
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dumpling-overview.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-distributed-import.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 1, 2023
dumpling-overview.md Outdated Show resolved Hide resolved
shichun-0415 and others added 2 commits February 1, 2023 19:03
dumpling-overview.md Outdated Show resolved Hide resolved
@shichun-0415 shichun-0415 added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 2, 2023
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8fad0d7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2023
@ti-chi-bot ti-chi-bot merged commit 3d78c84 into pingcap:master Feb 2, 2023
@shichun-0415 shichun-0415 deleted the external-storage-in-dumpling&lightning branch February 2, 2023 03:54
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #12361.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Feb 2, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12362.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Feb 2, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. require-LGT1 Indicates that the PR requires an LGTM. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants