Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add best practices doc for readonly nodes #12431

Merged
merged 5 commits into from Feb 16, 2023

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Feb 9, 2023

Signed-off-by: Aolin aolin.zhang@pingcap.com

What is changed, added or deleted? (Required)

Translate from pingcap/docs-cn#12819

  • Add a new doc to introduce how to configure read-only storage nodes.
  • Add a new value option learner for the system variable tidb_replica_read.
  • Add two Spark configuration items when configuring read-only storage nodes using TiSpark.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Feb 9, 2023
@Oreoxmt Oreoxmt requested review from v01dstar and removed request for ran-huang February 9, 2023 05:39
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 9, 2023
@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.6 and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2023
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Feb 9, 2023
@Oreoxmt Oreoxmt self-assigned this Feb 9, 2023
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 9, 2023
best-practices/readonly-nodes.md Outdated Show resolved Hide resolved
best-practices/readonly-nodes.md Outdated Show resolved Hide resolved
best-practices/readonly-nodes.md Outdated Show resolved Hide resolved
Co-authored-by: Yang Zhang <yang.zhang@pingcap.com>
Copy link

@v01dstar v01dstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

best-practices/readonly-nodes.md Outdated Show resolved Hide resolved
best-practices/readonly-nodes.md Outdated Show resolved Hide resolved
best-practices/readonly-nodes.md Outdated Show resolved Hide resolved
best-practices/readonly-nodes.md Outdated Show resolved Hide resolved
best-practices/readonly-nodes.md Outdated Show resolved Hide resolved
best-practices/readonly-nodes.md Outdated Show resolved Hide resolved
best-practices/readonly-nodes.md Outdated Show resolved Hide resolved
best-practices/readonly-nodes.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
tispark-overview.md Outdated Show resolved Hide resolved
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 13, 2023
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Feb 14, 2023

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2023
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Feb 16, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3a077de

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 16, 2023
@ti-chi-bot ti-chi-bot merged commit 8816c2d into pingcap:master Feb 16, 2023
@Oreoxmt Oreoxmt deleted the translate/docs-cn-12819 branch February 16, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants