Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiDB Monitoring Metrics: update key metrics from list to headings #12487

Merged
merged 3 commits into from Feb 14, 2023
Merged

TiDB Monitoring Metrics: update key metrics from list to headings #12487

merged 3 commits into from Feb 14, 2023

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Feb 14, 2023

What is changed, added or deleted? (Required)

Close pingcap/docs-cn#12312.

This PR lists these key metrics using H3 instead of list.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added type/enhancement This issue/PR improves documentation usability or supplements document content. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. ONCALL Relates to documentation oncall. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Feb 14, 2023
@Oreoxmt Oreoxmt self-assigned this Feb 14, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 14, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 14, 2023
@Oreoxmt Oreoxmt changed the title update key metrics from list to headings TiDB Monitoring Metrics: update key metrics from list to headings Feb 14, 2023
Oreoxmt
Oreoxmt commented Feb 14, 2023
View reviewed changes
grafana-tidb-dashboard.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 14, 2023
Oreoxmt
Oreoxmt commented Feb 14, 2023
View reviewed changes
grafana-tidb-dashboard.md Outdated Show resolved Hide resolved
shichun-0415
shichun-0415 approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2023
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Feb 14, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cab5b5d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@ti-chi-bot ti-chi-bot merged commit f019973 into pingcap:master Feb 14, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 14, 2023
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12488.

@Oreoxmt Oreoxmt deleted the fix/issue-12312 branch February 14, 2023 08:28
ti-chi-bot added a commit that referenced this pull request Feb 14, 2023
@ti-chi-bot
TiDB Monitoring Metrics: update key metrics from list to headings (#1…
4eec732 
…2487) (#12488)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. ONCALL Relates to documentation oncall. require-LGT1 Indicates that the PR requires an LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

把各个项目展示在导航栏
3 participants
@Oreoxmt @ti-chi-bot @shichun-0415