Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv config: align with Chinese #12648

Merged
merged 4 commits into from Mar 6, 2023
Merged

tikv config: align with Chinese #12648

merged 4 commits into from Mar 6, 2023

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Feb 23, 2023 •
edited

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt
tikv config: align with Chinese
3f8161d 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt Oreoxmt added type/enhancement This issue/PR improves documentation usability or supplements document content. translation/no-need No need to translate this PR. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. labels Feb 23, 2023
@Oreoxmt Oreoxmt self-assigned this Feb 23, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 23, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 23, 2023
@Oreoxmt
fix desc of raftdb.info-log-level
0670e3a 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Oreoxmt
Oreoxmt commented Feb 23, 2023
View reviewed changes
tikv-configuration-file.md
@@ -1710,7 +1719,7 @@ Configuration items related to `raftdb`

### `info-log-level`

+ Log levels of RocksDB
+ Log levels of RaftDB
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tabokie PTAL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oreoxmt Oreoxmt added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 labels Feb 27, 2023
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Feb 27, 2023

/verify

@Oreoxmt Oreoxmt added needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Feb 27, 2023
Oreoxmt
Oreoxmt commented Mar 6, 2023
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
@Oreoxmt @shichun-0415
Apply suggestions from code review
d7cbcfd 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Mar 6, 2023

/status LGT1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 6, 2023
shichun-0415
shichun-0415 approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tikv-configuration-file.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 6, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 6, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.1: #12758.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#12648
9a86c32 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 6, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.2: #12759.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#12648
b90210a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 6, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #12760.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#12648
772afcb 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@Oreoxmt Oreoxmt deleted the fix/tikv-configuration-file branch March 6, 2023 05:57
Oreoxmt added a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@Oreoxmt
tikv config: align with Chinese (pingcap#12648)
6b1b6e0 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
tikv config: align with Chinese (#12648) (#12755)
d5f5432
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@ti-chi-bot @Oreoxmt
tikv config: align with Chinese (pingcap#12648) (pingcap#12755)
c02020a 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@ti-chi-bot @Oreoxmt
tikv config: align with Chinese (pingcap#12648) (pingcap#12755)
c9b1aa4 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@ti-chi-bot @Oreoxmt
tikv config: align with Chinese (pingcap#12648) (pingcap#12755)
4c5fc03 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@ti-chi-bot @Oreoxmt
tikv config: align with Chinese (pingcap#12648) (pingcap#12755)
f19d385 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@ti-chi-bot @Oreoxmt
tikv config: align with Chinese (pingcap#12648) (pingcap#12755)
4444984 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
tikv config: align with Chinese (#12648) (#12756)
8deb94c
Oreoxmt added a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@Oreoxmt
tikv config: align with Chinese (pingcap#12648)
cfebedb 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
tikv config: align with Chinese (#12648) (#12757)
31a696a
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
tikv config: align with Chinese (#12648) (#12758)
c80c29e
Oreoxmt added a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@Oreoxmt
tikv config: align with Chinese (pingcap#12648)
3e437ac 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Oreoxmt added a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@Oreoxmt
tikv config: align with Chinese (pingcap#12648)
e268961 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
tikv config: align with Chinese (#12648) (#12759)
6a91e79
Oreoxmt added a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@Oreoxmt
tikv config: align with Chinese (pingcap#12648)
b651f18 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
tikv config: align with Chinese (#12648) (#12754)
4a40461
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
tikv config: align with Chinese (#12648) (#12752)
5dc9a30
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
tikv config: align with Chinese (#12648) (#12760)
1a3430e
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
tikv config: align with Chinese (#12648) (#12751)
ba7abaa
ti-chi-bot added a commit that referenced this pull request Mar 7, 2023
@ti-chi-bot
tikv config: align with Chinese (#12648) (#12753)
e39e368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabokie tabokie tabokie left review comments

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@Oreoxmt Oreoxmt

Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need No need to translate this PR. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Oreoxmt @ti-chi-bot @tabokie @shichun-0415