Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana-tidb-dashboard: update DDL related metrics #12750

Merged
merged 2 commits into from Mar 6, 2023
Merged

grafana-tidb-dashboard: update DDL related metrics #12750

merged 2 commits into from Mar 6, 2023

Conversation

shichun-0415
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 6, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2023
@shichun-0415 shichun-0415 added type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content. needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. ONCALL Relates to documentation oncall. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Mar 6, 2023
@shichun-0415 shichun-0415 requested review from Defined2014 and Oreoxmt and removed request for ran-huang March 6, 2023 04:06
@shichun-0415 @Defined2014
Update grafana-tidb-dashboard.md
2b59638 
Co-authored-by: Hangjie Mo <mohangjie1995@gmail.com>
Oreoxmt
Oreoxmt approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 6, 2023
@shichun-0415
Copy link
Contributor Author

/verify

@shichun-0415
Copy link
Contributor Author

/veriy

@shichun-0415
Copy link
Contributor Author

/verify

1 similar comment
@shichun-0415
Copy link
Contributor Author

/verify

@shichun-0415
Copy link
Contributor Author

/remove status LGT1
/status LGT2

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #12766.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@shichun-0415 @ti-chi-bot
This is an automated cherry-pick of pingcap#12750
896089c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 6, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #12767.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@shichun-0415 @ti-chi-bot
This is an automated cherry-pick of pingcap#12750
aa62f0e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 6, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #12768.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@shichun-0415 @ti-chi-bot
This is an automated cherry-pick of pingcap#12750
b18715f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 6, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12769.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 6, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #12770.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 6, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.0: #12771.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@shichun-0415 @ti-chi-bot
This is an automated cherry-pick of pingcap#12750
5057404 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 6, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.1: #12772.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@shichun-0415 @ti-chi-bot
This is an automated cherry-pick of pingcap#12750
1122477 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 6, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.2: #12773.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 6, 2023
@shichun-0415 @ti-chi-bot
This is an automated cherry-pick of pingcap#12750
dd9028e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@shichun-0415 shichun-0415 deleted the ddl-metric branch March 6, 2023 07:53
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
grafana-tidb-dashboard: update DDL related metrics (#12750) (#12766)
721ac51
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
grafana-tidb-dashboard: update DDL related metrics (#12750) (#12767)
d8f4336
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
grafana-tidb-dashboard: update DDL related metrics (#12750) (#12771)
9f9fa70
shichun-0415 added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot @shichun-0415
grafana-tidb-dashboard: update DDL related metrics (#12750) (#12772)
e5ad5f2 
* This is an automated cherry-pick of #12750

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* Update grafana-tidb-dashboard.md

---------

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
Co-authored-by: shichun-0415 <lishichun@pingcap.com>
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
grafana-tidb-dashboard: update DDL related metrics (#12750) (#12773)
71d4e6e
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
grafana-tidb-dashboard: update DDL related metrics (#12750) (#12770)
1379695
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
grafana-tidb-dashboard: update DDL related metrics (#12750) (#12769)
75163bc
ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
grafana-tidb-dashboard: update DDL related metrics (#12750) (#12768)
567d582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/bug-fix Fixes typos, wrong format, or other wrong or inaccurate document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shichun-0415 @ti-chi-bot @Defined2014 @Oreoxmt