Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partition: add key-partition document #12963

Merged
merged 15 commits into from Mar 23, 2023
Merged

Partition: add key-partition document #12963

merged 15 commits into from Mar 23, 2023

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Mar 20, 2023 •
edited by TonsnakeLin

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 20, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from Oreoxmt March 20, 2023 03:37
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2023
@qiancai qiancai removed the request for review from Oreoxmt March 20, 2023 03:37
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2023
@qiancai qiancai changed the title Update mysql-compatibility.md Partition: add key-partition document Mar 20, 2023
@qiancai qiancai requested a review from mjonss March 20, 2023 03:46
@qiancai qiancai mentioned this pull request Mar 20, 2023
Closed
15 tasks
@qiancai qiancai added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v7.0 labels Mar 20, 2023
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 20, 2023
qiancai
qiancai commented Mar 20, 2023
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
@qiancai qiancai self-assigned this Mar 20, 2023
lilin90
lilin90 reviewed Mar 20, 2023
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
@qiancai @lilin90
Update partitioned-table.md
c76bde7 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
qiancai
qiancai commented Mar 20, 2023
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
@qiancai qiancai requested a review from hfxsd March 20, 2023 06:22
hfxsd
hfxsd reviewed Mar 20, 2023
View reviewed changes
partitioned-table.md Outdated

Range partitioning, Range COLUMNS partitioning, List partitioning and List COLUMNS partitioning are used to resolve the performance issues caused by a large amount of deletions in the application, and support fast drop partition operations. Hash partitioning is used to scatter the data when there are a large amount of writes.
- Range partitioning, Range COLUMNS partitioning, List partitioning, and List COLUMNS partitioning are used to resolve the performance issues caused by a large number of deletions in the application, and support fast drop partition operations.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

support fast drop partition operations. 好像不太对

partitioned-table.md Show resolved Hide resolved
partitioned-table.md Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Show resolved Hide resolved
qiancai
qiancai commented Mar 20, 2023
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Show resolved Hide resolved
partitioned-table.md Show resolved Hide resolved
partitioned-table.md Show resolved Hide resolved
@qiancai @hfxsd
Apply suggestions from code review
4918543 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 20, 2023
mjonss
mjonss approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions

mysql-compatibility.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
qiancai and others added 2 commits March 21, 2023 10:55
@qiancai @mjonss
Apply suggestions from code review
84a8882 
Co-authored-by: Mattias Jonsson <mjonss@users.noreply.github.com>
@TonsnakeLin @mjonss
Update partitioned-table.md
1c55ec4 
Co-authored-by: Mattias Jonsson <mjonss@users.noreply.github.com>
@CLAassistant
Copy link

CLAassistant commented Mar 21, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

qiancai
qiancai commented Mar 21, 2023
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
qiancai
qiancai commented Mar 22, 2023
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
qiancai
qiancai commented Mar 22, 2023
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Mar 22, 2023
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
qiancai and others added 2 commits March 22, 2023 20:43
@qiancai @hfxsd
Apply suggestions from code review
02c8920 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@qiancai
Update partitioned-table.md
4190e66
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 23, 2023

/merge

@ti-chi-bot
Copy link
Member

@qiancai: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qiancai
Copy link
Collaborator Author

qiancai commented Mar 23, 2023

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2023
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 23, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4190e66

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2023
@ti-chi-bot ti-chi-bot merged commit 1f3279f into pingcap:master Mar 23, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 left review comments

@hfxsd hfxsd hfxsd approved these changes

@mjonss mjonss mjonss approved these changes

@TonsnakeLin TonsnakeLin TonsnakeLin approved these changes

Assignees

@qiancai qiancai

Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@qiancai @ti-chi-bot @CLAassistant @mjonss @lilin90 @hfxsd @TonsnakeLin