system-variables: update the default value of datadir #13336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
the
missing-translation-status
hfxsd
added
translation/doing
ti-chi-bot
bot
added
the
size/XS
hfxsd
added
type/compatibility-or-feature-change
ti-chi-bot
bot
added
the
size/XS
dveeden
approved these changes
Apr 24, 2023
system-variables.md
Outdated
| - A value in the format of `ip_address:port` indicates the PD server that TiDB connects to on startup. | ||
| - Default value: it depends on the component and the deployment method. | ||
| - `/tmp/tidb` when you set `"unistore"` for [`--store`](/command-line-flags-for-tidb-configuration.md#store) | ||
| - ${pd-ip}:${pd-port} when you use TiUP or Operator to deploy TiDB amd set `"tikv"` for [`--store`](/command-line-flags-for-tidb-configuration.md#store) |
There was a problem hiding this comment.
Suggested change
| - ${pd-ip}:${pd-port} when you use TiUP or Operator to deploy TiDB amd set `"tikv"` for [`--store`](/command-line-flags-for-tidb-configuration.md#store) | |
| - ${pd-ip}:${pd-port} when you use TiKV, which is the default for TiUP and TiDB Operator for Kubernetes deployments. |
Co-authored-by: Daniël van Eeden <github@myname.nl>
…into datadir-default-value
15 tasks
hfxsd
added
translation/done
hfxsd
commented
Apr 24, 2023
hfxsd
commented
Apr 24, 2023
ran-huang
approved these changes
Apr 25, 2023
ti-chi-bot
bot
added
size/S
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 6c52958
|
ti-chi-bot
bot
added
the
status/can-merge
15 tasks
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/docs
that referenced
this pull request
Apr 25, 2023
|
In response to a cherrypick label: new pull request created to branch |
15 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/docs
that referenced
this pull request
Apr 25, 2023
15 tasks
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/docs
that referenced
this pull request
Apr 25, 2023
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
as tittle
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?