Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiflash: add description about behavior after executing ALTER DATABASE #13675

Merged
merged 4 commits into from May 25, 2023
Merged

tiflash: add description about behavior after executing ALTER DATABASE #13675

merged 4 commits into from May 25, 2023

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented May 25, 2023

What is changed, added or deleted? (Required)

Add a note that newly added tables after ALTER DATABASE is executed cannot be replicated to TiFlash automatically.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 25, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@hfxsd hfxsd self-assigned this May 25, 2023
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 25, 2023
@hfxsd hfxsd added type/enhancement This issue/PR improves documentation usability or supplements document content. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. ONCALL Relates to documentation oncall. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 25, 2023
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 25, 2023
qiancai
qiancai approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2023
@hfxsd @qiancai
Update tiflash/create-tiflash-replicas.md
7d636bb 
Co-authored-by: Grace Cai <qqzczy@126.com>
@hfxsd hfxsd added the require-LGT1 Indicates that the PR requires an LGTM. label May 25, 2023
@hfxsd
Copy link
Collaborator Author

hfxsd commented May 25, 2023

/verify

@hfxsd
Copy link
Collaborator Author

hfxsd commented May 25, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 7d636bb

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit d39c6be into pingcap:master May 25, 2023
9 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request May 25, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #13676.

@ti-chi-bot ti-chi-bot mentioned this pull request May 25, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #13677.

@ti-chi-bot ti-chi-bot mentioned this pull request May 25, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #13678.

@ti-chi-bot ti-chi-bot mentioned this pull request May 25, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #13679.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout release-7.1: error checking out release-7.1: exit status 1. output: error: pathspec 'release-7.1' did not match any file(s) known to git

ti-chi-bot bot pushed a commit that referenced this pull request May 25, 2023
@ti-chi-bot
tiflash: add description about behavior after executing ALTER DATABASE (
be3118b 
#13675) (#13676)
ti-chi-bot bot pushed a commit that referenced this pull request May 25, 2023
@ti-chi-bot
tiflash: add description about behavior after executing ALTER DATABASE (
0f9cb29 
#13675) (#13678)
ti-chi-bot bot pushed a commit that referenced this pull request May 25, 2023
@ti-chi-bot
tiflash: add description about behavior after executing ALTER DATABASE (
60388e2 
#13675) (#13679)
ti-chi-bot bot pushed a commit that referenced this pull request May 25, 2023
@ti-chi-bot
tiflash: add description about behavior after executing ALTER DATABASE (
5af02c5 
#13675) (#13677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

Assignees

@hfxsd hfxsd

Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. ONCALL Relates to documentation oncall. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hfxsd @ti-chi-bot @qiancai