Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add a limit for smooth upgrade #13713

Merged
merged 4 commits into from May 31, 2023
Merged

*: add a limit for smooth upgrade #13713

merged 4 commits into from May 31, 2023

Conversation

ran-huang
Copy link
Contributor

@ran-huang ran-huang commented May 30, 2023 •
edited

First-time contributors' checklist

What is changed, added or deleted? (Required)

This PR is used to add a limit for smooth upgrade.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang ran-huang added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v7.1 This PR/issue applies to TiDB v7.1. labels May 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 30, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 30, 2023
@ran-huang
add a limit for smooth upgrade
791923f 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang ran-huang self-assigned this May 30, 2023
qiancai
qiancai reviewed May 30, 2023
View reviewed changes
smooth-upgrade-tidb.md Outdated Show resolved Hide resolved
qiancai
qiancai approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM

qiancai
qiancai approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 30, 2023
@ran-huang @qiancai
Update smooth-upgrade-tidb.md
6a0cb8a 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ran-huang ran-huang added the require-LGT1 Indicates that the PR requires an LGTM. label May 31, 2023
@ran-huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 31, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 6a0cb8a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4087ab0 into pingcap:master May 31, 2023
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #13721.

@ti-chi-bot ti-chi-bot mentioned this pull request May 31, 2023
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request May 31, 2023
@ti-chi-bot
*: add a limit for smooth upgrade (#13713) (#13721)
87e1173
@ran-huang ran-huang deleted the zimuxia/add-limits-14052 branch May 31, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@zimulala zimulala Awaiting requested review from zimulala

Assignees

@ran-huang ran-huang

Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v7.1 This PR/issue applies to TiDB v7.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ran-huang @ti-chi-bot @qiancai